You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by wushujames <gi...@git.apache.org> on 2017/09/21 07:24:13 UTC
[GitHub] kafka pull request #3931: Minor: Fix testUniqueErrorCodes unit test failure
GitHub user wushujames opened a pull request:
https://github.com/apache/kafka/pull/3931
Minor: Fix testUniqueErrorCodes unit test failure
I'm not really sure if I'm doing the right thing here, but I thought I'd give it a shot and try to fix the unit test breakage. Running ```./gradlew :clients:unitTest``` now passes.
Fix error code collision accidentally introduced when merging in https://github.com/apache/kafka/commit/5f6393f9b17cce17ded7a00e439599dfa77deb2d#diff-b119227df7efa3ffeb7fe69e49ff1afeR541
There were two Error 59's
Requesting review by @tombentley
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wushujames/kafka KAFKA-5856.buildfix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3931.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3931
----
commit b3c738ba1dd8771c1e6a088222e3e9d850758aa1
Author: James Cheng <jy...@yahoo.com>
Date: 2017-09-21T07:14:47Z
Fix error code collision accidentally introduced when merging in https://github.com/apache/kafka/commit/5f6393f9b17cce17ded7a00e439599dfa77deb2d#diff-b119227df7efa3ffeb7fe69e49ff1afeR541
----
---
[GitHub] kafka pull request #3931: Minor: Fix testUniqueErrorCodes unit test failure
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/kafka/pull/3931
---