You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by "Carsten Ziegeler (Resolved) (JIRA)" <ji...@apache.org> on 2011/11/15 09:33:52 UTC

[jira] [Resolved] (SLING-2279) ReferrerFilter should not reverse lookup the IPs of interfaces

     [ https://issues.apache.org/jira/browse/SLING-2279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Ziegeler resolved SLING-2279.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: Security 1.0.0

Thanks for your patch - I've applied it in revision 1202087
                
> ReferrerFilter should not reverse lookup the IPs of interfaces
> --------------------------------------------------------------
>
>                 Key: SLING-2279
>                 URL: https://issues.apache.org/jira/browse/SLING-2279
>             Project: Sling
>          Issue Type: Improvement
>          Components: Extensions
>         Environment: contrib / extensions / org.apache.sling.security-0.5.0-SNAPSHOT.jar
>            Reporter: Tobias Bocanegra
>            Assignee: Carsten Ziegeler
>             Fix For: Security 1.0.0
>
>         Attachments: referrer-r1200559.patch
>
>
> The o.a.s.security.impl.ReferrerFilter initializes the getDefaultAllowedReferrers() with the hostnames of the local interfaces. I doubt that this has any meaning in a productive environment, as the server most probably runs behind a loadbalancer or proxy. the problem with this initialization is that it might result in a reverse DNS lookup, which can be very slow.
> suggest to remove the hostnames from the default referrers:

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira