You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2011/02/04 15:29:33 UTC
svn commit: r1067181 - in
/commons/proper/exec/trunk/src/test/java/org/apache/commons/exec:
DefaultExecutorTest.java LogOutputStreamTest.java StandAloneTest.java
environment/EnvironmentUtilTest.java
Author: ggregory
Date: Fri Feb 4 14:29:32 2011
New Revision: 1067181
URL: http://svn.apache.org/viewvc?rev=1067181&view=rev
Log:
Remove some but not all System.out.println calls.
Modified:
commons/proper/exec/trunk/src/test/java/org/apache/commons/exec/DefaultExecutorTest.java
commons/proper/exec/trunk/src/test/java/org/apache/commons/exec/LogOutputStreamTest.java
commons/proper/exec/trunk/src/test/java/org/apache/commons/exec/StandAloneTest.java
commons/proper/exec/trunk/src/test/java/org/apache/commons/exec/environment/EnvironmentUtilTest.java
Modified: commons/proper/exec/trunk/src/test/java/org/apache/commons/exec/DefaultExecutorTest.java
URL: http://svn.apache.org/viewvc/commons/proper/exec/trunk/src/test/java/org/apache/commons/exec/DefaultExecutorTest.java?rev=1067181&r1=1067180&r2=1067181&view=diff
==============================================================================
--- commons/proper/exec/trunk/src/test/java/org/apache/commons/exec/DefaultExecutorTest.java (original)
+++ commons/proper/exec/trunk/src/test/java/org/apache/commons/exec/DefaultExecutorTest.java Fri Feb 4 14:29:32 2011
@@ -72,8 +72,6 @@ public class DefaultExecutorTest extends
protected void setUp() throws Exception {
- System.out.println(">>> Executing " + getName() + " ...");
-
// delete the marker file
this.foreverOutputFile.getParentFile().mkdirs();
if(this.foreverOutputFile.exists()) {
@@ -487,9 +485,8 @@ public class DefaultExecutorTest extends
int exitValue = executor.execute(cl);
fis.close();
String result = baos.toString().trim();
- System.out.println(result);
- assertTrue(result.indexOf("Finished reading from stdin") > 0);
- assertFalse(exec.isFailure(exitValue));
+ assertTrue(result, result.indexOf("Finished reading from stdin") > 0);
+ assertFalse("exitValue=" + exitValue, exec.isFailure(exitValue));
}
else if(OS.isFamilyWindows()) {
System.err.println("The code samples to do that in windows look like a joke ... :-( .., no way I'm doing that");
@@ -739,10 +736,6 @@ public class DefaultExecutorTest extends
int exitValue = exec.execute(cmdl);
String result = baos.toString().trim();
- System.out.println("=== Expected ===");
- System.out.println(expected);
- System.out.println("=== Result ===");
- System.out.println(result);
assertFalse(exec.isFailure(exitValue));
assertEquals(expected, result);
}
@@ -797,10 +790,6 @@ public class DefaultExecutorTest extends
int exitValue = exec.execute(cmdl);
String result = baos.toString().trim();
- System.out.println("=== Expected ===");
- System.out.println(expected);
- System.out.println("=== Result ===");
- System.out.println(result);
assertFalse(exec.isFailure(exitValue));
if(OS.isFamilyUnix()) {
Modified: commons/proper/exec/trunk/src/test/java/org/apache/commons/exec/LogOutputStreamTest.java
URL: http://svn.apache.org/viewvc/commons/proper/exec/trunk/src/test/java/org/apache/commons/exec/LogOutputStreamTest.java?rev=1067181&r1=1067180&r2=1067181&view=diff
==============================================================================
--- commons/proper/exec/trunk/src/test/java/org/apache/commons/exec/LogOutputStreamTest.java (original)
+++ commons/proper/exec/trunk/src/test/java/org/apache/commons/exec/LogOutputStreamTest.java Fri Feb 4 14:29:32 2011
@@ -41,7 +41,6 @@ public class LogOutputStreamTest extends
protected void setUp() throws Exception {
- System.out.println(">>> Executing " + getName() + " ...");
this.systemOut = new SystemLogOutputStream(1);
this.exec.setStreamHandler(new PumpStreamHandler(systemOut, systemOut));
}
Modified: commons/proper/exec/trunk/src/test/java/org/apache/commons/exec/StandAloneTest.java
URL: http://svn.apache.org/viewvc/commons/proper/exec/trunk/src/test/java/org/apache/commons/exec/StandAloneTest.java?rev=1067181&r1=1067180&r2=1067181&view=diff
==============================================================================
--- commons/proper/exec/trunk/src/test/java/org/apache/commons/exec/StandAloneTest.java (original)
+++ commons/proper/exec/trunk/src/test/java/org/apache/commons/exec/StandAloneTest.java Fri Feb 4 14:29:32 2011
@@ -36,7 +36,6 @@ public class StandAloneTest extends Test
public void testMe() throws Exception {
if(OS.isFamilyUnix()) {
File testScript = TestUtil.resolveScriptForOS("./src/test/scripts/standalone");
- System.out.println("Executing the following test script : " + testScript.getAbsolutePath());
Executor exec = new DefaultExecutor();
exec.setStreamHandler(new PumpStreamHandler());
CommandLine cl = new CommandLine(testScript);
Modified: commons/proper/exec/trunk/src/test/java/org/apache/commons/exec/environment/EnvironmentUtilTest.java
URL: http://svn.apache.org/viewvc/commons/proper/exec/trunk/src/test/java/org/apache/commons/exec/environment/EnvironmentUtilTest.java?rev=1067181&r1=1067180&r2=1067181&view=diff
==============================================================================
--- commons/proper/exec/trunk/src/test/java/org/apache/commons/exec/environment/EnvironmentUtilTest.java (original)
+++ commons/proper/exec/trunk/src/test/java/org/apache/commons/exec/environment/EnvironmentUtilTest.java Fri Feb 4 14:29:32 2011
@@ -64,7 +64,7 @@ public class EnvironmentUtilTest extends
for(int i=0; i<envArgs.length; i++) {
assertNotNull("Entry "+i+" should not be null",envArgs[i]);
assertTrue("Entry "+i+" should not be empty",envArgs[i].length() > 0);
- System.out.println(envArgs[i]);
+ // System.out.println(envArgs[i]);
}
}