You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by junegunn <gi...@git.apache.org> on 2018/04/10 06:32:57 UTC

[GitHub] nifi pull request #2621: NIFI-5064 Fixes and improvements to PutKudu process...

GitHub user junegunn opened a pull request:

    https://github.com/apache/nifi/pull/2621

    NIFI-5064 Fixes and improvements to PutKudu processor

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
        - *No, I intentionally made separate commits so that it's easier to review each change.*
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/junegunn/nifi put-kudu-improvements

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2621.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2621
    
----
commit f5b9ed17e47fb463d84f15c873dcaab84fdf685f
Author: Junegunn Choi <ju...@...>
Date:   2018-04-03T07:36:54Z

    Bump kudu-client version to 1.7.0

commit e4b9abcc98b3fa8f55b522f7302b80841f3df123
Author: Junegunn Choi <ju...@...>
Date:   2018-04-03T07:40:24Z

    Deprecate "Skip head line" property of PutKudu

commit 8672a4ddba0c146dfd05fee263bb9f2df8cfc1b7
Author: Junegunn Choi <ju...@...>
Date:   2018-04-03T07:38:07Z

    Fix IllegalArgumentException on 16-bit integer columns

commit 9e8305710ec7111ecd8c7cc214abeeefa51f6219
Author: Junegunn Choi <ju...@...>
Date:   2018-04-06T04:45:46Z

    Fix IllegalArgumentException on 8-bit integer columns

commit 71c2e9fc6b142ee0b7177948cf7497077e6596c4
Author: Junegunn Choi <ju...@...>
Date:   2018-04-03T07:39:13Z

    Fix NullPointerException on null/missing values

commit ab8f7047a79ddd60a9c061bb58c192bda813ea46
Author: Junegunn Choi <ju...@...>
Date:   2018-04-06T04:48:39Z

    Add support for DECIMAL types

commit 77ed66946e7bf627e15f17aa488a49b39918f0ee
Author: Junegunn Choi <ju...@...>
Date:   2018-04-10T04:48:59Z

    Fix PutKudu to properly handle server-side errors

----


---

[GitHub] nifi issue #2621: NIFI-5064 Fixes and improvements to PutKudu processor

Posted by pvillard31 <gi...@git.apache.org>.

Github user pvillard31 commented on the issue:

    https://github.com/apache/nifi/pull/2621
  
    Hi @junegunn - I tested your changes on a simple workflow and what you propose here makes a lot of sense. I don't see any breaking change and the error handling looks OK to me. I'm a +1 and will merge to master. Thanks for your work and your very detailed JIRA. Really appreciated.


---

[GitHub] nifi pull request #2621: NIFI-5064 Fixes and improvements to PutKudu process...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/nifi/pull/2621


---

[GitHub] nifi issue #2621: NIFI-5064 Fixes and improvements to PutKudu processor

Posted by junegunn <gi...@git.apache.org>.

Github user junegunn commented on the issue:

    https://github.com/apache/nifi/pull/2621
  
    Thanks!


---