You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/02 08:09:01 UTC

[GitHub] [flink] zhijiangW commented on issue #9985: [FLINK-10968][kubernetes] Implement TaskManager Entrypoint for Kubernetes.

zhijiangW commented on issue #9985: [FLINK-10968][kubernetes] Implement TaskManager Entrypoint for Kubernetes.
URL: https://github.com/apache/flink/pull/9985#issuecomment-560281196
 
 
   Thanks for the fix @wangyang0918 !
   
   It is almost good for me now.  I am not quite sure whether it is necessary to supplement a unit test for `TaskManagerRunner.runTaskManagerSecurely` to verify the passed args are correctly loaded into configuration.  Because the new `KubernetesTaskExecutorRunner` relies on this method which seems not be covered by tests before.
   
   In addition, if we can decouple this PR with previous `KubernetesResourceManager`, then it can be merged separately to not be blocked by precious PRs.  The only reference by this PR is `KubernetesResourceManager.ENV_RESOURCE_ID`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services