You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/01/25 17:38:35 UTC
[GitHub] russaa opened a new pull request #149: CB-12277: (android) avoid NullPointerException when removing splash-screen
russaa opened a new pull request #149: CB-12277: (android) avoid NullPointerException when removing splash-screen
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/149
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
android
### What does this PR do?
Avoids NullPointerException when removing splash-screen.
As described in the issue [CB-12277](https://issues.apache.org/jira/browse/CB-12277), this problem does not occur determinstically, but only sometimes.
### What testing has been done on this change?
manual testing as described in comments of issue [CB-12277](https://issues.apache.org/jira/browse/CB-12277), as there is no interface in the test-harness yet for automatically restarting apps.
the manual procedure was as follows:
* start app, wait for splash-screen to disappear, restart app immediately
* without patch, the NullPointerException always occurred within 5 repeats of this procedure
* with patch, the NullPointerExeption did not occur within 20 repeats
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- ~~[ ] Added automated test coverage as appropriate for this change.~~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org