[GitHub] [camel-k] tadayosi commented on pull request #3901: fix(#3896): Fix dependency inspector supporting property placeholders

[GitBox <gi...@apache.org>]

tadayosi commented on PR #3901:
URL: https://github.com/apache/camel-k/pull/3901#issuecomment-1352510771

   Thanks a lot Christoph for taking care of this issue!
   
   As already commented in the review, I don't think checking only `:` in uri can cover all edge cases. For example:
   https://github.com/apache/camel-kamelets/blob/main/kamelets/elasticsearch-search-source.kamelet.yaml#L110
   ```
               uri: "{{local-es}}:{{clusterName}}"
   ```
   This kamelet has `uri` that contains `:` but still uses a property placeholder. A better logic should be:
   
   1. Try to decode the uri.
   2. Check the returned scheme; if it's `nil`, check the uri on whether a placeholder is used at the place of scheme.
   3. If a placeholder is used return silently; otherwise throw an error.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org