You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Uwe Schindler (JIRA)" <ji...@apache.org> on 2009/11/11 00:52:27 UTC
[jira] Created: (LUCENE-2052) Scan method signatures and add
varargs where possible
Scan method signatures and add varargs where possible
-----------------------------------------------------
Key: LUCENE-2052
URL: https://issues.apache.org/jira/browse/LUCENE-2052
Project: Lucene - Java
Issue Type: Improvement
Affects Versions: 3.0
Reporter: Uwe Schindler
Assignee: Uwe Schindler
Fix For: 3.0
I changed a lot of signatures, but there may be more. The important ones like MultiReader and MultiSearcher are already done. This applies also to contrib. Varargs are no backwards break, they stay arrays as before.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2052) Scan method signatures and add
varargs where possible
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777851#action_12777851 ]
Uwe Schindler commented on LUCENE-2052:
---------------------------------------
Yes, that's right. For stopwords a varargs ctor is not really "the right thing". Varargs are more for cases like instantiating a MultiReader with 5 IndexReaders or something like that. Or adding a bunch of clauses to a SpanQuery.
The varargs Set<?> is one unit, arrays are not needed (they are there because of BW compatibility). All these ctors except Set<?> should have been deprecated in 2.9.
> Scan method signatures and add varargs where possible
> -----------------------------------------------------
>
> Key: LUCENE-2052
> URL: https://issues.apache.org/jira/browse/LUCENE-2052
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 3.0
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 3.0
>
> Attachments: LUCENE-2052.patch, LUCENE-2052.patch, LUCENE-2052_fa.patch
>
>
> I changed a lot of signatures, but there may be more. The important ones like MultiReader and MultiSearcher are already done. This applies also to contrib. Varargs are no backwards break, they stay arrays as before.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2052) Scan method signatures and add
varargs where possible
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-2052:
--------------------------------
Attachment: LUCENE-2052_fa.patch
uwe, here is one i found that got skipped in LUCENE-1987
> Scan method signatures and add varargs where possible
> -----------------------------------------------------
>
> Key: LUCENE-2052
> URL: https://issues.apache.org/jira/browse/LUCENE-2052
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 3.0
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 3.0
>
> Attachments: LUCENE-2052.patch, LUCENE-2052.patch, LUCENE-2052_fa.patch
>
>
> I changed a lot of signatures, but there may be more. The important ones like MultiReader and MultiSearcher are already done. This applies also to contrib. Varargs are no backwards break, they stay arrays as before.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2052) Scan method signatures and add
varargs where possible
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776179#action_12776179 ]
Uwe Schindler commented on LUCENE-2052:
---------------------------------------
Is there any eclipse plugin/refactoring/cleanup that helps when doing this? Cannot find anything :-(
> Scan method signatures and add varargs where possible
> -----------------------------------------------------
>
> Key: LUCENE-2052
> URL: https://issues.apache.org/jira/browse/LUCENE-2052
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 3.0
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 3.0
>
>
> I changed a lot of signatures, but there may be more. The important ones like MultiReader and MultiSearcher are already done. This applies also to contrib. Varargs are no backwards break, they stay arrays as before.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2052) Scan method signatures and add
varargs where possible
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-2052:
----------------------------------
Attachment: LUCENE-2052.patch
Updated patch, as there may be a backwards comp problem (but only if you recompile!) if you try to override a varargs method with an array param (which is not possible). Removed the varargs from docFreq(Term[]) because of that again.
Also added changes.txt.
> Scan method signatures and add varargs where possible
> -----------------------------------------------------
>
> Key: LUCENE-2052
> URL: https://issues.apache.org/jira/browse/LUCENE-2052
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 3.0
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 3.0
>
> Attachments: LUCENE-2052.patch, LUCENE-2052.patch
>
>
> I changed a lot of signatures, but there may be more. The important ones like MultiReader and MultiSearcher are already done. This applies also to contrib. Varargs are no backwards break, they stay arrays as before.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2052) Scan method signatures and add
varargs where possible
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777836#action_12777836 ]
Uwe Schindler commented on LUCENE-2052:
---------------------------------------
Thanks, I didn't check contrib.
> Scan method signatures and add varargs where possible
> -----------------------------------------------------
>
> Key: LUCENE-2052
> URL: https://issues.apache.org/jira/browse/LUCENE-2052
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 3.0
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 3.0
>
> Attachments: LUCENE-2052.patch, LUCENE-2052.patch, LUCENE-2052_fa.patch
>
>
> I changed a lot of signatures, but there may be more. The important ones like MultiReader and MultiSearcher are already done. This applies also to contrib. Varargs are no backwards break, they stay arrays as before.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-2052) Scan method signatures and add
varargs where possible
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler resolved LUCENE-2052.
-----------------------------------
Resolution: Fixed
Committed revision: 836248
> Scan method signatures and add varargs where possible
> -----------------------------------------------------
>
> Key: LUCENE-2052
> URL: https://issues.apache.org/jira/browse/LUCENE-2052
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 3.0
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 3.0
>
> Attachments: LUCENE-2052.patch, LUCENE-2052.patch, LUCENE-2052_fa.patch
>
>
> I changed a lot of signatures, but there may be more. The important ones like MultiReader and MultiSearcher are already done. This applies also to contrib. Varargs are no backwards break, they stay arrays as before.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2052) Scan method signatures and add
varargs where possible
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777846#action_12777846 ]
Robert Muir commented on LUCENE-2052:
-------------------------------------
bq. Thanks, I didn't check contrib.
I didn't really completely check, not sure really where we should have varargs there.
(it does not make sense for stopwords to me, but then I feel all we need is Set<?> instead of file, varargs, hashtable, and all the other constructors we have)
still i'd rather have consistency for now.
> Scan method signatures and add varargs where possible
> -----------------------------------------------------
>
> Key: LUCENE-2052
> URL: https://issues.apache.org/jira/browse/LUCENE-2052
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 3.0
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 3.0
>
> Attachments: LUCENE-2052.patch, LUCENE-2052.patch, LUCENE-2052_fa.patch
>
>
> I changed a lot of signatures, but there may be more. The important ones like MultiReader and MultiSearcher are already done. This applies also to contrib. Varargs are no backwards break, they stay arrays as before.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2052) Scan method signatures and add
varargs where possible
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-2052:
----------------------------------
Attachment: LUCENE-2052.patch
Here a patch that adds more varargs where it makes sense (e.g. MultiSearcher ctor to pass Searchables, adding more than one sub query, merge boolean queries and so on - everywhere, where the array is not the meaning but more a unlimited list of parameters).
If somebody finds something in addition, speak load!
> Scan method signatures and add varargs where possible
> -----------------------------------------------------
>
> Key: LUCENE-2052
> URL: https://issues.apache.org/jira/browse/LUCENE-2052
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 3.0
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 3.0
>
> Attachments: LUCENE-2052.patch
>
>
> I changed a lot of signatures, but there may be more. The important ones like MultiReader and MultiSearcher are already done. This applies also to contrib. Varargs are no backwards break, they stay arrays as before.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org