You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2025/03/03 18:41:01 UTC
rusackas opened a new pull request, #32488:
URL: https://github.com/apache/superset/pull/32488
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
tooltips don't render HTML.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
Before:
After:
<img width="379" alt="Screenshot 2025-03-03 at 11 37 37 AM" src="https://github.com/user-attachments/assets/aa58ffe9-230c-44f4-a75b-336ca77f988c" />
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Posted by "korbit-ai[bot] (via GitHub)" <gi...@apache.org>.
korbit-ai[bot] commented on code in PR #32488:
URL: https://github.com/apache/superset/pull/32488#discussion_r1978293793
##########
superset-frontend/plugins/plugin-chart-pivot-table/src/plugin/controlPanel.tsx:
##########
@@ -442,7 +442,7 @@ const config: ControlPanelConfig = {
renderTrigger: true,
default: true,
description: t(
- 'Renders table cells as HTML when applicable. For example, HTML <a> tags will be rendered as hyperlinks.',
+ 'Renders table cells as HTML when applicable. For example, HTML <a> tags will be rendered as hyperlinks.',
),
Review Comment:
Hi @rusackas, I completely understand that HTML rendering by default seems like a more convenient option. However, as Korbit's bot pointed out, enabling it may potentially expose to XSS vulnerabilities if user-provided data is rendered. Could we explore implementing a proper HTML sanitization process before rendering? That way, we can maintain convenience while ensuring security. Let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #32488:
URL: https://github.com/apache/superset/pull/32488
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Posted by "korbit-ai[bot] (via GitHub)" <gi...@apache.org>.
korbit-ai[bot] commented on code in PR #32488:
URL: https://github.com/apache/superset/pull/32488#discussion_r1978277696
##########
superset-frontend/plugins/plugin-chart-pivot-table/src/plugin/controlPanel.tsx:
##########
@@ -442,7 +442,7 @@ const config: ControlPanelConfig = {
renderTrigger: true,
default: true,
description: t(
- 'Renders table cells as HTML when applicable. For example, HTML <a> tags will be rendered as hyperlinks.',
+ 'Renders table cells as HTML when applicable. For example, HTML <a> tags will be rendered as hyperlinks.',
),
Review Comment:
### XSS Risk: Unsanitized HTML Rendering in Table Cells <sub></sub>
<details>
<summary>Tell me more</summary>
###### What is the issue?
The code enables HTML rendering in table cells by default (allow_render_html.default: true) without explicit sanitization, which could lead to XSS vulnerabilities if user-provided data is rendered.
###### Why this matters
If malicious users can inject HTML/JavaScript into the data displayed in the table cells, it could execute in users' browsers leading to cross-site scripting attacks.
###### Suggested change ∙ *Feature Preview*
Either disable HTML rendering by default (set default: false) or ensure proper HTML sanitization is implemented before rendering. Add documentation warning about the security implications:
```typescript
config: {
type: 'CheckboxControl',
label: t('Render columns in HTML format'),
renderTrigger: true,
default: false,
description: t(
'Renders table cells as HTML when applicable. Warning: Only enable this if you trust the data source as it may expose XSS vulnerabilities.',
),
}
```
</details>
<sub>
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/e599579f-37fc-419d-9949-ad64d9becbf9?suggestedFixEnabled=true)
💬 Chat with Korbit by mentioning @korbit-ai.
</sub>
<!--- korbi internal id:e7b0a212-0736-4df5-a824-0238819b34da -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Posted by "korbit-ai[bot] (via GitHub)" <gi...@apache.org>.
korbit-ai[bot] commented on PR #32488:
URL: https://github.com/apache/superset/pull/32488#issuecomment-2695248942
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment `/korbit-review`.
> Your admin can change your review schedule in the [Korbit Console](https://app.korbit.ai/settings)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #32488:
URL: https://github.com/apache/superset/pull/32488#discussion_r1978293500
##########
superset-frontend/plugins/plugin-chart-pivot-table/src/plugin/controlPanel.tsx:
##########
@@ -442,7 +442,7 @@ const config: ControlPanelConfig = {
renderTrigger: true,
default: true,
description: t(
- 'Renders table cells as HTML when applicable. For example, HTML <a> tags will be rendered as hyperlinks.',
+ 'Renders table cells as HTML when applicable. For example, HTML <a> tags will be rendered as hyperlinks.',
),
Review Comment:
meh.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org