You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/04/18 02:29:02 UTC

[GitHub] [couchdb] nickva opened a new pull request #3513: feat: work around get_stacktrace deprecation/removal

nickva opened a new pull request #3513:
URL: https://github.com/apache/couchdb/pull/3513


   This patch introduces a macro and inserts it everywhere we catch errors
   and then generate a stacktrace.
   
   So far the only thing that is a little bit ugly is that in two places,
   I had to add a header include dependency on couch_db.erl where those
   modules didn’t have any ties to couchdb/* before, alas. I’d be willing
   to duplicate the macros in those modules, if we don’t want the include
   dependency.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] nickva commented on a change in pull request #3513: feat: work around get_stacktrace deprecation/removal

Posted by GitBox <gi...@apache.org>.
nickva commented on a change in pull request #3513:
URL: https://github.com/apache/couchdb/pull/3513#discussion_r615330732



##########
File path: Makefile
##########
@@ -187,7 +187,7 @@ exunit: export ERL_AFLAGS = -config $(shell pwd)/rel/files/eunit.config
 exunit: export COUCHDB_QUERY_SERVER_JAVASCRIPT = $(shell pwd)/bin/couchjs $(shell pwd)/share/server/main.js
 exunit: export COUCHDB_TEST_ADMIN_PARTY_OVERRIDE=1
 exunit: couch elixir-init setup-eunit elixir-check-formatted elixir-credo
-	@mix test --cover --trace $(EXUNIT_OPTS)

Review comment:
       It's from Jan's cherry-picked commit. Should I remove it?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] nickva merged pull request #3513: feat: work around get_stacktrace deprecation/removal

Posted by GitBox <gi...@apache.org>.
nickva merged pull request #3513:
URL: https://github.com/apache/couchdb/pull/3513


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] nickva commented on a change in pull request #3513: feat: work around get_stacktrace deprecation/removal

Posted by GitBox <gi...@apache.org>.
nickva commented on a change in pull request #3513:
URL: https://github.com/apache/couchdb/pull/3513#discussion_r615331549



##########
File path: Makefile
##########
@@ -187,7 +187,7 @@ exunit: export ERL_AFLAGS = -config $(shell pwd)/rel/files/eunit.config
 exunit: export COUCHDB_QUERY_SERVER_JAVASCRIPT = $(shell pwd)/bin/couchjs $(shell pwd)/share/server/main.js
 exunit: export COUCHDB_TEST_ADMIN_PARTY_OVERRIDE=1
 exunit: couch elixir-init setup-eunit elixir-check-formatted elixir-credo
-	@mix test --cover --trace $(EXUNIT_OPTS)

Review comment:
       Removed it. Good catch




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] nickva commented on a change in pull request #3513: feat: work around get_stacktrace deprecation/removal

Posted by GitBox <gi...@apache.org>.
nickva commented on a change in pull request #3513:
URL: https://github.com/apache/couchdb/pull/3513#discussion_r615330732



##########
File path: Makefile
##########
@@ -187,7 +187,7 @@ exunit: export ERL_AFLAGS = -config $(shell pwd)/rel/files/eunit.config
 exunit: export COUCHDB_QUERY_SERVER_JAVASCRIPT = $(shell pwd)/bin/couchjs $(shell pwd)/share/server/main.js
 exunit: export COUCHDB_TEST_ADMIN_PARTY_OVERRIDE=1
 exunit: couch elixir-init setup-eunit elixir-check-formatted elixir-credo
-	@mix test --cover --trace $(EXUNIT_OPTS)

Review comment:
       It's from Jan's cherry-picked commit
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] wohali commented on a change in pull request #3513: feat: work around get_stacktrace deprecation/removal

Posted by GitBox <gi...@apache.org>.
wohali commented on a change in pull request #3513:
URL: https://github.com/apache/couchdb/pull/3513#discussion_r615330724



##########
File path: Makefile
##########
@@ -187,7 +187,7 @@ exunit: export ERL_AFLAGS = -config $(shell pwd)/rel/files/eunit.config
 exunit: export COUCHDB_QUERY_SERVER_JAVASCRIPT = $(shell pwd)/bin/couchjs $(shell pwd)/share/server/main.js
 exunit: export COUCHDB_TEST_ADMIN_PARTY_OVERRIDE=1
 exunit: couch elixir-init setup-eunit elixir-check-formatted elixir-credo
-	@mix test --cover --trace $(EXUNIT_OPTS)

Review comment:
       unrelated?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] nickva commented on a change in pull request #3513: feat: work around get_stacktrace deprecation/removal

Posted by GitBox <gi...@apache.org>.
nickva commented on a change in pull request #3513:
URL: https://github.com/apache/couchdb/pull/3513#discussion_r615330732



##########
File path: Makefile
##########
@@ -187,7 +187,7 @@ exunit: export ERL_AFLAGS = -config $(shell pwd)/rel/files/eunit.config
 exunit: export COUCHDB_QUERY_SERVER_JAVASCRIPT = $(shell pwd)/bin/couchjs $(shell pwd)/share/server/main.js
 exunit: export COUCHDB_TEST_ADMIN_PARTY_OVERRIDE=1
 exunit: couch elixir-init setup-eunit elixir-check-formatted elixir-credo
-	@mix test --cover --trace $(EXUNIT_OPTS)

Review comment:
       It's from Jan's cherry-picked commit. I'll remove it, I think




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org