You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/08/18 20:55:01 UTC

[GitHub] [spark] srowen commented on issue #25423: [SPARK-28701][test-hadoop3.2][test-java11][k8s] adding java11 support for pull request builds

srowen commented on issue #25423: [SPARK-28701][test-hadoop3.2][test-java11][k8s] adding java11 support for pull request builds
URL: https://github.com/apache/spark/pull/25423#issuecomment-522354637
 
 
   I don't believe `-release` is an option for cross-compiling, because the scala plugin doesn't seem to support it. I think it's safer to use JDK 8; what's the issue with that other than having two JDKs installed, but, we already do. Definitely if you figure it out, we can try it out.
   
   Without the `java.version` change, even using JDK 11 you're not really testing vs 11's classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org