[GitHub] [bookkeeper] zymap commented on a diff in pull request #3799: Support retry logic for auto recovery

["zymap (via GitHub)" <gi...@apache.org>]

zymap commented on code in PR #3799:
URL: https://github.com/apache/bookkeeper/pull/3799#discussion_r1113963118


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/AuditorElector.java:
##########
@@ -191,8 +192,14 @@ public void run() {
                         Thread.currentThread().interrupt();
                         submitShutdownTask();
                     } catch (Exception e) {
-                        LOG.error("Exception while performing auditor election", e);
-                        submitShutdownTask();
+                        if (e.getCause() instanceof KeeperException.ConnectionLossException

Review Comment:
   It's better to retry with a delay time I think.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org