You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "infdahai (via GitHub)" <gi...@apache.org> on 2023/04/07 15:17:28 UTC
[GitHub] [arrow] infdahai opened a new pull request, #34969: GH-34945: [Docs][C++] update cmake_mini_version
infdahai opened a new pull request, #34969:
URL: https://github.com/apache/arrow/pull/34969
1. add cmake_minimum_required(3.16) .
2. the version is based on https://github.com/apache/arrow/issues/34921.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34969: GH-34945: [C++][Docs] update cmake_mini_version
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34969:
URL: https://github.com/apache/arrow/pull/34969#issuecomment-1500383565
:warning: GitHub issue #34945 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34969: GH-34945: [Docs][C++] update cmake_mini_version
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34969:
URL: https://github.com/apache/arrow/pull/34969#issuecomment-1500381833
:warning: GitHub issue #34945 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34969: GH-34945: [C++][Docs] Add missing cmake_minimum_required() to example
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34969:
URL: https://github.com/apache/arrow/pull/34969#issuecomment-1500918013
Benchmark runs are scheduled for baseline = 62fea1686093ca69c1347e17b495b8c2fee55a92 and contender = f4446c0f99b427a513f4a18d8ca3874fd5c56cee. f4446c0f99b427a513f4a18d8ca3874fd5c56cee is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/2a0111925682470b8103595787d635ce...dad4e4820c8f4a4d92e551f81dcc68cd/)
[Finished :arrow_down:0.33% :arrow_up:0.09%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2afe6d720fae4556bca90f2de4c92c07...077658d94e294b808ecfbe1d463025ba/)
[Finished :arrow_down:0.51% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f2704e3fc9104b88bdffaa758c6724aa...a3550623abc4420486e0586ec022ed91/)
[Finished :arrow_down:0.28% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/dfa7d5c2b9064110a793a3ee49c67ad3...b7a1e81c7a8941ee83276b180c9e0239/)
Buildkite builds:
[Finished] [`f4446c0f` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2656)
[Finished] [`f4446c0f` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2689)
[Finished] [`f4446c0f` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2654)
[Finished] [`f4446c0f` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2680)
[Finished] [`62fea168` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2655)
[Finished] [`62fea168` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2688)
[Finished] [`62fea168` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2653)
[Finished] [`62fea168` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2679)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #34969: GH-34945: [C++][Docs] update cmake_mini_version
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #34969:
URL: https://github.com/apache/arrow/pull/34969#discussion_r1160879030
##########
docs/source/cpp/build_system.rst:
##########
@@ -45,7 +45,9 @@ This minimal ``CMakeLists.txt`` file compiles a ``my_example.cc`` source
file into an executable linked with the Arrow C++ shared library:
.. code-block:: cmake
-
+
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34969: GH-34945: [Docs][C++] update cmake_mini_version
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34969:
URL: https://github.com/apache/arrow/pull/34969#issuecomment-1500381808
* Closes: #34945
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #34969: GH-34945: [C++][Docs] Add missing cmake_minimum_required() to example
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #34969:
URL: https://github.com/apache/arrow/pull/34969#discussion_r1160898973
##########
docs/source/cpp/build_system.rst:
##########
@@ -45,7 +45,8 @@ This minimal ``CMakeLists.txt`` file compiles a ``my_example.cc`` source
file into an executable linked with the Arrow C++ shared library:
.. code-block:: cmake
-
+ cmake_minimum_required(VERSION 3.16)
Review Comment:
We don't require CMake 3.16 yet but it's OK because we'll do it soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34969: GH-34945: [C++][Docs] Add missing cmake_minimum_required() to example
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34969:
URL: https://github.com/apache/arrow/pull/34969#issuecomment-1500552889
:warning: GitHub issue #34945 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] infdahai commented on pull request #34969: GH-34945: [C++][Docs] Add missing cmake_minimum_required() to example
Posted by "infdahai (via GitHub)" <gi...@apache.org>.
infdahai commented on PR #34969:
URL: https://github.com/apache/arrow/pull/34969#issuecomment-1500782906
> +1
>
> Thanks!
>
> Could you use pull request template instead of removing it entirely next time?
ok. I made a mistake
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #34969: GH-34945: [C++][Docs] Add missing cmake_minimum_required() to example
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #34969:
URL: https://github.com/apache/arrow/pull/34969
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org