[GitHub] [tvm] areusch commented on a diff in pull request #12416: [Target] Remove deprecated parameters from target

[GitBox <gi...@apache.org>]

areusch commented on code in PR #12416:
URL: https://github.com/apache/tvm/pull/12416#discussion_r946222001


##########
apps/wasm-standalone/wasm-graph/tools/build_graph_lib.py:
##########
@@ -72,7 +72,7 @@ def build_graph_lib(opt_level):
     shape_dict = {input_name: img_data.shape}
 
     mod, params = relay.frontend.from_onnx(onnx_model, shape_dict)
-    target = "llvm -mtriple=wasm32-unknown-unknown -mattr=+simd128 --system-lib"
+    target = "llvm -mtriple=wasm32-unknown-unknown -mattr=+simd128"

Review Comment:
   i think we need to keep --system-lib passed to Executor config here. can you audit the other places you removed `--system-lib` and ensure the Executor passed to relay.build has it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org