You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/08/03 01:03:17 UTC

[GitHub] [rocketmq] RongtongJin commented on a diff in pull request #4767: [ISSUE #4766] add error log

RongtongJin commented on code in PR #4767:
URL: https://github.com/apache/rocketmq/pull/4767#discussion_r936147879


##########
store/src/main/java/org/apache/rocketmq/store/CommitLog.java:
##########
@@ -532,6 +532,7 @@ public DispatchRequest checkMessageAndReturnSize(java.nio.ByteBuffer byteBuffer,
 
             return dispatchRequest;
         } catch (Exception e) {
+            log.error("CommitLog: check message failed", e);

Review Comment:
   There is no need to print logs here, because rocketmq master-slave replication is is based on streams rather than messages , so it is common to dispatch half messages  If you print logs here, there will be a lot of dirty logs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org