[GitHub] [cordova-plugin-splashscreen] mosabab commented on pull request #270: [Android] Add size specs for Splash Screens

[GitBox <gi...@apache.org>]

mosabab commented on pull request #270:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/270#issuecomment-641208362


   > Thank you for your PR.
   > 
   > I was going to mimic some of the iOS documentation and have a `Android-specific Information` section with a table that describes the android sizes for splashscreens, similar to what we have for the iOS's [multi-image launch screen](https://github.com/apache/cordova-plugin-splashscreen#multi-image-launch-screen)
   > 
   > Like so:
   > 
   > size	portrait	landscape
   > ldpi	200x320	320x200
   > mdpi	320x480	480x320
   > ...	...	...
   > I think this makes it easier to link to (with an appropriate header), and makes the documentation a bit cleaner. What do you think?
   
   I agree with you, because Android section for splash screen details not fit as well.
   
   And also if you insert the details about `<preference name="SplashMaintainAspectRatio" value="true" />` after the table
   Because it is useful and look better on screen if we use this preference.
   
   Regards 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org