You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Chris M. Hostetter (Jira)" <ji...@apache.org> on 2019/10/24 20:03:00 UTC
[jira] [Commented] (SOLR-13871) JettySolrRunner should stop trying
to re-use ports on re-start
[ https://issues.apache.org/jira/browse/SOLR-13871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16959187#comment-16959187 ]
Chris M. Hostetter commented on SOLR-13871:
-------------------------------------------
This will definitely require a lot of "fixes" in test code where nodes are restarted to eliminate expectations that the same URL will work before and after restart.
It may also depend on a lot of changes through out the SolrCloud logic to eliminate any assumptions in the code regarding the "port" of a given node after it restarts. (i think {{genericNodeNames=true}} helps here but i'm not sure to what extent ... I honestly have no idea how much of our code currently expects that a given node will always use hte same port ... maybe none, maybe a lot)
If it proves totally impossible to make this work because of intractable SolrCloud limitations, then we might want to consider revamping as many tests as possible that currently depend on doing a full stop/start of ports, to instead use "proxies" to partition ports when viable for the tests instead.
(i know that's used in some of the "partitioning" tests ... but it t may not be suitable for tests where we're trying to see how a node itself behaves on shutdown when it's part of a cluster)
----
FWIW: I'm not planning on digging into this right now, I just wanted to get the issue for tracking purposes and in case other people w/more understanding of the underlying issues wanted to chime in with thoughts...
particularly if there are specific architectural reasons why a SolrCloud won't work well if a node restarts with a different port then it originally registered with.
> JettySolrRunner should stop trying to re-use ports on re-start
> --------------------------------------------------------------
>
> Key: SOLR-13871
> URL: https://issues.apache.org/jira/browse/SOLR-13871
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Chris M. Hostetter
> Priority: Major
>
> JettySolrRunner currently has special logic in it's {{start()}} method that will cause it (by default) to try to rebind to the port it was previously assigned if it's restarting and configured with port '0'
> ie: the first time it starts the OS assigns the port, after that it tries to re-use that same port.
> This is a bad idea in general, and leads to (very slow) BindException failures in a lot of jenkins tests where nodes are restarted.
> Example...
> {noformat}
> [junit4] 2> NOTE: reproduce with: ant test -Dtestcase=ShardSplitTest -Dtests.method=testSplitWithChaosMonkey -Dtests.seed=9097C20E8E9ACC68 -Dtes
> ts.multiplier=2 -Dtests.nightly=true -Dtests.slow=true -Dtests.linedocsfile=/home/jenkins/jenkins-slave/workspace/Lucene-Solr-NightlyTests-master/test
> -data/enwiki.random.lines.txt -Dtests.locale=so-SO -Dtests.timezone=Etc/GMT+9 -Dtests.asserts=true -Dtests.file.encoding=UTF-8
> [junit4] ERROR 81.2s J1 | ShardSplitTest.testSplitWithChaosMonkey <<<
> [junit4] > Throwable #1: java.net.BindException: Address already in use
> [junit4] > at __randomizedtesting.SeedInfo.seed([9097C20E8E9ACC68:1BB011DFCF9C67EC]:0)
> [junit4] > at java.base/sun.nio.ch.Net.bind0(Native Method)
> [junit4] > at java.base/sun.nio.ch.Net.bind(Net.java:461)
> [junit4] > at java.base/sun.nio.ch.Net.bind(Net.java:453)
> [junit4] > at java.base/sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:227)
> [junit4] > at java.base/sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:80)
> [junit4] > at org.eclipse.jetty.server.ServerConnector.openAcceptChannel(ServerConnector.java:342)
> [junit4] > at org.eclipse.jetty.server.ServerConnector.open(ServerConnector.java:308)
> [junit4] > at org.eclipse.jetty.server.AbstractNetworkConnector.doStart(AbstractNetworkConnector.java:80)
> [junit4] > at org.eclipse.jetty.server.ServerConnector.doStart(ServerConnector.java:236)
> [junit4] > at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
> [junit4] > at org.eclipse.jetty.server.Server.doStart(Server.java:396)
> [junit4] > at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
> [junit4] > at org.apache.solr.client.solrj.embedded.JettySolrRunner.retryOnPortBindFailure(JettySolrRunner.java:569)
> [junit4] > at org.apache.solr.client.solrj.embedded.JettySolrRunner.start(JettySolrRunner.java:508)
> [junit4] > at org.apache.solr.client.solrj.embedded.JettySolrRunner.start(JettySolrRunner.java:476)
> [junit4] > at org.apache.solr.cloud.api.collections.ShardSplitTest.testSplitWithChaosMonkey(ShardSplitTest.java:499)
> {noformat}
> Ideally JettySolrRunner's default behavior should b to just trust it's config – binding to a random port (even on restart, even if diff from it's previous port) if configured with '0'.
> Callers – including tests – should eliminate any assumptions in their code that the port will be consistent for the life of a JettySolrRunner (ie: accept that the URL may change anytime stop/start is called)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org