[GitHub] [iceberg] johnclara commented on a change in pull request #1918: WIP: SymmetricKeyEncryptionManager

[GitBox <gi...@apache.org>]

johnclara commented on a change in pull request #1918:
URL: https://github.com/apache/iceberg/pull/1918#discussion_r591801931



##########
File path: crypto/src/main/java/org/apache/iceberg/encryption/keys/KeyMetadata.java
##########
@@ -0,0 +1,30 @@
+package org.apache.iceberg.encryption.keys;
+
+/**
+ * {@link KeyMetadata} metadata that is persistable into a byte array within a ManifestFile.
+ *
+ * <p>individual dekProviders are resposible for serializing and deserializing their

Review comment:
       old naming. Should be KeyProvider and KeyMaterials




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org