[GitHub] [calcite] laurentgo commented on a change in pull request #1130: [CALCITE-2865] FilterProjectTransposeRule generates wrong traitSet when copyFilter/Project is true

[GitBox <gi...@apache.org>]

laurentgo commented on a change in pull request #1130: [CALCITE-2865] FilterProjectTransposeRule generates wrong traitSet when copyFilter/Project is true	
URL: https://github.com/apache/calcite/pull/1130#discussion_r270226064
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/rel/rules/FilterProjectTransposeRule.java
 ##########
 @@ -155,8 +158,12 @@ public void onMatch(RelOptRuleCall call) {
     final RelBuilder relBuilder = call.builder();
     RelNode newFilterRel;
     if (copyFilter) {
-      newFilterRel = filter.copy(filter.getTraitSet(), project.getInput(),
-          simplifyFilterCondition(newCondition, call));
+      final RelNode input = project.getInput();
+      final RelTraitSet traitSet = filter.getTraitSet()
+          .replaceIfs(RelCollationTraitDef.INSTANCE,
 
 Review comment:
   wouldn't it be better to use the relbuilder to create a new filter instead since it would defer to *Filter#create (which already has the correct logic), or fix Filter#copy method instead?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services