You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/09/18 23:08:00 UTC
[jira] [Commented] (SAMZA-1868) Refactor KafkaSystemAdmin from using SimpleConsumer

    [ https://issues.apache.org/jira/browse/SAMZA-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16619863#comment-16619863 ] 

ASF GitHub Bot commented on SAMZA-1868:
---------------------------------------

GitHub user sborya opened a pull request:

    https://github.com/apache/samza/pull/647

    SAMZA-1868: New kafka consumer admin (using high level consumer)

    Rewrite of KafkaSystemAdmin in java, using new KafkaSystemConsumer (based on high level kafka consumer).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sborya/samza NewConsumerAdmin

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/647.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #647
    
----
commit a4846e5ff302a3309451d4a5fc190de94cd78caa
Author: Boris S <bo...@...>
Date:   2018-09-14T17:21:21Z

    Replaced systemAdmin with java system admin

commit be4f747f2f82171d5cddee72ab943df567daed12
Author: Boris S <bo...@...>
Date:   2018-09-14T17:21:44Z

    added java system admin

commit 2f8d248c88baf8b107f07bef39f0400aa406b182
Author: Boris S <bo...@...>
Date:   2018-09-17T18:27:40Z

    Addes new java samza system amdin

commit 16395e1f587e6a7929590fe3e8bc962bd27e5e96
Author: Boris S <bo...@...>
Date:   2018-09-17T20:26:12Z

    adjusted tests

commit 9a7aa2b0865702e819eaae0bce7ee07142c2e56b
Author: Boris S <bo...@...>
Date:   2018-09-17T21:07:29Z

    fixed the tests

commit 999cf846fa86477e22f9e81504257239b35f0533
Author: Boris S <bo...@...>
Date:   2018-09-18T18:46:01Z

    added  createAdmin for test

commit 956057e00b5c29859dbe24261ad87b5be9f3a143
Author: Boris S <bo...@...>
Date:   2018-09-18T19:00:47Z

    remove KafkaSystemAdmin

commit 415ce8a923e08cdeecb397fe15b397d76986ada5
Author: Boris S <bo...@...>
Date:   2018-09-18T20:26:23Z

    merge

commit bbb5916e890a070bf75dc9a6889383106387528e
Author: Boris S <bo...@...>
Date:   2018-09-18T21:08:49Z

    changed clientId to idPrefix

commit 828ef461d054e5622b0206b9eb815771f0570162
Author: Boris S <bo...@...>
Date:   2018-09-18T21:16:17Z

    create admin client in constructor instead of in start()

commit ac9b5940f0dd12125d82a32ff30533b7caa3f7d3
Author: Boris S <bo...@...>
Date:   2018-09-18T21:18:37Z

    Merge branch 'NewConsumer2' into NewConsumerAdmin

commit eda593fdc995678ecbcfcaec9b80ebf9ef3afaec
Author: Boris S <bo...@...>
Date:   2018-09-18T21:32:39Z

    adjusted tests

commit 99b008601f3e72b9cec97690f1caa917c4ab957f
Author: Boris S <bo...@...>
Date:   2018-09-18T22:46:23Z

    change name to SamzaKafkaSystemAdmin

----


> Refactor KafkaSystemAdmin from using SimpleConsumer
> ---------------------------------------------------
>
>                 Key: SAMZA-1868
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1868
>             Project: Samza
>          Issue Type: Sub-task
>            Reporter: Boris Shkolnik
>            Assignee: Boris Shkolnik
>            Priority: Major
>
> Convert it into using KafkaSystemConsumer.
> Aslo, move getClientId into KafkaConsumerConfig.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)