You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "chennaji9 (via GitHub)" <gi...@apache.org> on 2026/10/09 14:25:45 UTC
[PR] [ISSUE #11339] test(filter): pin LogicExpression truth table and short-circuit [rocketmq]
chennaji9 opened a new pull request, #11348:
URL: https://github.com/apache/rocketmq/pull/11348
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
Fixes #11339
### Brief Description
Adds a parameterized `LogicExpressionTest` pinning the SQL92 boolean logic every property-filter subscription compiles through:
- the full 3x3 operand matrix (TRUE / FALSE / UNKNOWN) for both `AND` and `OR`, including UNKNOWN propagation (`null AND TRUE` = UNKNOWN, `null OR FALSE` = UNKNOWN);
- `matches()` treats UNKNOWN as no-match;
- short-circuit proofs using evaluation-counting operands: the right operand is provably not evaluated when `FALSE AND …` / `TRUE OR …` is already decided, and provably is evaluated otherwise.
Test-only change; no production code touched.
### How Did You Test This Change?
`mvn -pl filter -Dtest=LogicExpressionTest -Dsurefire.failIfNoSpecifiedTests=false test` (JDK 11, PR base commit): `Tests run: 54, Failures: 0, Errors: 0` (9 parameter combinations x 6 test methods).
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #11339] test(filter): pin LogicExpression truth table and short-circuit [rocketmq]
Posted by "chennaji9 (via GitHub)" <gi...@apache.org>.
chennaji9 commented on PR #11348:
URL: https://github.com/apache/rocketmq/pull/11348#issuecomment-6259266680
Hi @RongtongJin, sorry for the ping — this PR has been open for a while without a review yet. The change is small and focused (pin LogicExpression truth table and short-circuit), and all tests and CI pass on my side. Would you mind taking a look when you get a chance? If it looks good, merging it would be much appreciated — happy to adjust anything if needed. Thanks a lot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #11339] test(filter): pin LogicExpression truth table and short-circuit [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #11348:
URL: https://github.com/apache/rocketmq/pull/11348#issuecomment-6084175859
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/11348?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 49.69%. Comparing base ([`9ea2ccd`](https://app.codecov.io/gh/apache/rocketmq/commit/9ea2ccdc2b41445aee5e177e14e501d606f5a1ed?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`2615309`](https://app.codecov.io/gh/apache/rocketmq/commit/26153095adfabf2e6942fe20f63d466e41912d81?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #11348 +/- ##
=============================================
- Coverage 49.73% 49.69% -0.05%
+ Complexity 14348 14340 -8
=============================================
Files 1390 1390
Lines 103246 103246
Branches 13502 13502
=============================================
- Hits 51354 51310 -44
- Misses 45696 45742 +46
+ Partials 6196 6194 -2
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/rocketmq/pull/11348?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #11339] test(filter): pin LogicExpression truth table and short-circuit [rocketmq]
Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on PR #11348:
URL: https://github.com/apache/rocketmq/pull/11348#issuecomment-6130746015
**Issue Evaluation**
Category: `type/enhancement` | Status: **Confirmed**
The need for direct LogicExpression truth-table tests is valid. The SQL92 three-valued logic (TRUE/FALSE/UNKNOWN) used in property-filter subscriptions currently lacks explicit coverage for:
- The full 3×3 operand matrix for `AND` and `OR`
- UNKNOWN propagation semantics
- Short-circuit evaluation guarantees
**Impact:** Without these tests, regressions in filter logic could silently change message routing behavior.
**Severity:** Medium (test gap in a correctness-critical path)
The proposed parameterized test approach (9 combinations × 6 methods = 54 test cases) provides comprehensive coverage. Test-only change with no production code impact.
---
*Automated evaluation by github-manager-bot*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org