You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/08/03 08:09:21 UTC

[GitHub] [rocketmq-operator] gobbq opened a new issue, #123: The stateful variables in share.go

gobbq opened a new issue, #123:
URL: https://github.com/apache/rocketmq-operator/issues/123

   **BUG REPORT**
   
   The `NameServersStr` variable in `share.go` will be empty if we restart or recreate the operator pods, logs as follows:
   ![image](https://user-images.githubusercontent.com/9428795/182555803-ac8119cc-07f5-43e9-a96d-590d4177eebd.png)
   
   
   **SUGGESTION**
   
   The operator uses share.go to store the state of name service, such as endpoints, initialized and so on.
   This leads to the presence of states in operator, for most cases we only want the operator to do some sure actions when reconciled and not rely on the state in memory, for example, creating broker resources if `nameservice.status.initialized=true`.
   
   For the further version, we'd better to remove the `share.go` in the operator.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq-operator] caigy closed issue #123: The stateful variables in share.go

Posted by GitBox <gi...@apache.org>.
caigy closed issue #123: The stateful variables in share.go
URL: https://github.com/apache/rocketmq-operator/issues/123


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org