You are viewing a plain text version of this content. The canonical link for it is here.
Posted to apreq-cvs@httpd.apache.org by pg...@apache.org on 2006/05/21 07:36:09 UTC
svn commit: r408136 - /httpd/apreq/trunk/build/version_check.pl
Author: pgollucci
Date: Sat May 20 22:36:08 2006
New Revision: 408136
URL: http://svn.apache.org/viewvc?rev=408136&view=rev
Log:
Add pre of Archive::Tar (only for win32)
Using v1.29 as thats what I have installed.
Reported by: steve.hay@uk.radan.com
Message ID: <44...@uk.radan.com>
Modified:
httpd/apreq/trunk/build/version_check.pl
Modified: httpd/apreq/trunk/build/version_check.pl
URL: http://svn.apache.org/viewvc/httpd/apreq/trunk/build/version_check.pl?rev=408136&r1=408135&r2=408136&view=diff
==============================================================================
--- httpd/apreq/trunk/build/version_check.pl (original)
+++ httpd/apreq/trunk/build/version_check.pl Sat May 20 22:36:08 2006
@@ -38,6 +38,11 @@
$ExtUtils::MakeMaker::VERSION;
}
+sub ta_version {
+ require Archive::Tar;
+ $Archive::Tar::VERSION;
+}
+
sub mp2_version {
eval {
require mod_perl2;
@@ -74,6 +79,12 @@
"Test::More" => { version => "0.47", test => \&tm_version },
);
+$perl_glue{'Archive::Tar'} = {
+ version => "1.29",
+ test => \&ta_version,
+ comment => 'Win32 only',
+ };
+
my %test = (
"Test::Inline" => { version => "0.16", test => \&ti_version },
);
Re: svn commit: r408136 - /httpd/apreq/trunk/build/version_check.pl
Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
Randy Kobes wrote:
> So I think requiring version "0" may be safest.
Committed revision 408571.
--
------------------------------------------------------------------------
Philip M. Gollucci (pgollucci@p6m7g8.com) 323.219.4708
Consultant / http://p6m7g8.net/Resume/resume.shtml
Senior Software Engineer - TicketMaster - http://ticketmaster.com
1024D/A79997FA F357 0FDD 2301 6296 690F 6A47 D55A 7172 A799 97F
"It takes a minute to have a crush on someone, an hour to like someone,
and a day to love someone, but it takes a lifetime to forget someone..."
Re: svn commit: r408136 - /httpd/apreq/trunk/build/version_check.pl
Posted by Randy Kobes <ra...@theoryx5.uwinnipeg.ca>.
On Sun, 21 May 2006, Philip M. Gollucci wrote:
>> I'd prefer that no version of Archive::Tar be specified
>> for Win32, or perhaps even no such prerequisite at all;
>> it's a core module in ActivePerl, and has a history
>> of some instability on Win32 - an upgrade may break
>> things on the local system.
>>
> I was trying to address this from Steven Hay's post:
>>> - When I ran "perl Makefile.PL --with-apache2=C:/apache2" I got an >>error
> from win32/Configure.pl about Archive-Tar being missing, but >>this is not
> mentioned in the PREREQUISITES file and was not checked by >>test_prereq in
> Makefile.PL before calling this script.
It's a trade-off - Steve builds his own perl, so having
Archive::Tar as a prerequisite makes sense, but especially
requiring a particular version may mess up an ActivePerl
with an older version. So I think requiring version "0"
may be safest.
> I'm fine with whatever you say is best... I'm not a MS guy.
>
> I guess people on cygwin using the cygwin perl shouldn't be using the
> win32/Configure.pl. (I don't think Steven is)
That's right, on both counts.
--
best regards,
Randy
Re: svn commit: r408136 - /httpd/apreq/trunk/build/version_check.pl
Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
> I'd prefer that no version of Archive::Tar be specified
> for Win32, or perhaps even no such prerequisite at all;
> it's a core module in ActivePerl, and has a history
> of some instability on Win32 - an upgrade may break
> things on the local system.
>
I was trying to address this from Steven Hay's post:
>>- When I ran "perl Makefile.PL --with-apache2=C:/apache2" I got an
>>error from win32/Configure.pl about Archive-Tar being missing, but
>>this is not mentioned in the PREREQUISITES file and was not checked
by >>test_prereq in Makefile.PL before calling this script.
I'm fine with whatever you say is best... I'm not a MS guy.
I guess people on cygwin using the cygwin perl shouldn't be using the
win32/Configure.pl. (I don't think Steven is)
--
------------------------------------------------------------------------
Philip M. Gollucci (pgollucci@p6m7g8.com) 323.219.4708
Consultant / http://p6m7g8.net/Resume/resume.shtml
Senior Software Engineer - TicketMaster - http://ticketmaster.com
1024D/A79997FA F357 0FDD 2301 6296 690F 6A47 D55A 7172 A799 97F
"It takes a minute to have a crush on someone, an hour to like someone,
and a day to love someone, but it takes a lifetime to forget someone..."
Re: svn commit: r408136 - /httpd/apreq/trunk/build/version_check.pl
Posted by Randy Kobes <ra...@theoryx5.uwinnipeg.ca>.
On Sun, 21 May 2006, pgollucci@apache.org wrote:
> Author: pgollucci
> Date: Sat May 20 22:36:08 2006
> New Revision: 408136
>
> URL: http://svn.apache.org/viewvc?rev=408136&view=rev
> Log:
> Add pre of Archive::Tar (only for win32)
> Using v1.29 as thats what I have installed.
I'd prefer that no version of Archive::Tar be specified
for Win32, or perhaps even no such prerequisite at all;
it's a core module in ActivePerl, and has a history
of some instability on Win32 - an upgrade may break
things on the local system.
--
best regards,
Randy