[jira] Commented: (THRIFT-883) Extend ByteBuffer support to non-array-backed ByteBuffers

["Bryan Duxbury (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12977898#action_12977898 ] 

Bryan Duxbury commented on THRIFT-883:
--------------------------------------

Thanks for the patch, Pavel. Unfortunately, this is just the tip of the iceberg. There are lots of other places that need to respect the dichotomy. I'll incorporate your changes when I get around to the full patch.

> Extend ByteBuffer support to non-array-backed ByteBuffers
> ---------------------------------------------------------
>
>                 Key: THRIFT-883
>                 URL: https://issues.apache.org/jira/browse/THRIFT-883
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Java - Library
>    Affects Versions: 0.4
>            Reporter: Bryan Duxbury
>            Assignee: Bryan Duxbury
>             Fix For: 0.7
>
>         Attachments: TBinaryProtocol-writeBinary.patch
>
>
> Binary fields are backed by ByteBuffers that wrap byte arrays, and all the protocol code assumes that every ByteBuffer is of this type. However, now that the structs setters allow ByteBuffer arguments, it would be nice to support other kinds of ByteBuffers, like those that are allocated direct.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.