You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by mi...@apache.org on 2016/03/30 17:19:18 UTC
svn commit: r1737123 - in /maven/plugins/trunk/maven-changes-plugin/src:
it/announce-generate/src/changes/changes.xml
main/java/org/apache/maven/plugin/changes/IssueAdapter.java
Author: michaelo
Date: Wed Mar 30 15:19:18 2016
New Revision: 1737123
URL: http://svn.apache.org/viewvc?rev=1737123&view=rev
Log:
[MCHANGES-364] DueTo is always empty
Modified:
maven/plugins/trunk/maven-changes-plugin/src/it/announce-generate/src/changes/changes.xml
maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/changes/IssueAdapter.java
Modified: maven/plugins/trunk/maven-changes-plugin/src/it/announce-generate/src/changes/changes.xml
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-changes-plugin/src/it/announce-generate/src/changes/changes.xml?rev=1737123&r1=1737122&r2=1737123&view=diff
==============================================================================
--- maven/plugins/trunk/maven-changes-plugin/src/it/announce-generate/src/changes/changes.xml (original)
+++ maven/plugins/trunk/maven-changes-plugin/src/it/announce-generate/src/changes/changes.xml Wed Mar 30 15:19:18 2016
@@ -40,7 +40,7 @@ under the License.
<dueto name="John Doe" email="john@doe.com"/>
<dueto name="Jane Doe"/>
</action>
- <action dev="you" type="update" issue="MCHANGES-999" system="bugzilla">
+ <action dev="you" type="update" issue="MCHANGES-999" system="bugzilla" due-to="External Submitter">
Handle different issue systems.
<fixes issue="bug-12345"/>
<dueto name="John Doe" email="john@doe.com"/>
Modified: maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/changes/IssueAdapter.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/changes/IssueAdapter.java?rev=1737123&r1=1737122&r2=1737123&view=diff
==============================================================================
--- maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/changes/IssueAdapter.java (original)
+++ maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/changes/IssueAdapter.java Wed Mar 30 15:19:18 2016
@@ -32,7 +32,7 @@ import java.util.Map;
/**
* An adapter that can adapt data models from other issue management system to the data models used in the changes.xml
* file.
- *
+ *
* @author Dennis Lundberg
* @version $Id$
* @since 2.4
@@ -60,7 +60,7 @@ public class IssueAdapter
/**
* Adapt a <code>List</code> of <code>Issue</code>s to a <code>List</code> of <code>Release</code>s.
- *
+ *
* @param issues The issues
* @return A list of releases
*/
@@ -105,7 +105,7 @@ public class IssueAdapter
/**
* Create an <code>Action</code> from an issue.
- *
+ *
* @param issue The issue to extract the information from
* @return An <code>Action</code>
*/
@@ -131,9 +131,7 @@ public class IssueAdapter
action.setDev( issue.getAssignee() );
- // Set dueTo to the empty String instead of null to make Velocity happy
- action.setDueTo( "" );
- // action.setDueTo( issue.getReporter() );
+ action.setDueTo( issue.getReporter() == null ? "" : issue.getReporter() );
action.setAction( issue.getSummary() );
return action;