[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24750: [SPARK-26192][MESOS][2.4] Retrieve enableFetcherCache option from submission for driver URIs

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #24750: [SPARK-26192][MESOS][2.4] Retrieve enableFetcherCache option from submission for driver URIs
URL: https://github.com/apache/spark/pull/24750#discussion_r289253404
 
 

 ##########
 File path: resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
 ##########
 @@ -430,6 +429,9 @@ private[spark] class MesosClusterScheduler(
   }
 
   private def getDriverUris(desc: MesosDriverDescription): List[CommandInfo.URI] = {
+    val useFetchCache = conf.getBoolean("spark.mesos.fetcherCache.enable", false) ||
+      desc.conf.getBoolean("spark.mesos.fetcherCache.enable", false)
 
 Review comment:
   Ur, this one looks the opposite direction. Could you check this again?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org