You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "Demon-Liang (via GitHub)" <gi...@apache.org> on 2023/06/28 09:32:44 UTC

[GitHub] [incubator-celeborn] Demon-Liang opened a new pull request, #1641: [CELEBORN-728] Fix expired app directory's clean up bug on HDFS

Demon-Liang opened a new pull request, #1641:
URL: https://github.com/apache/incubator-celeborn/pull/1641

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     - Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
     - Be sure to keep the PR description updated to reflect all changes.
     - Please write your PR title to summarize what this PR proposes.
     - If possible, provide a concise example to reproduce the issue for a faster review.
   -->
   
   ### What changes were proposed in this pull request?
   Fix a bug of app directory's clean up logic. 
   
   
   ### Why are the changes needed?
   In old implementation, expired app directories will not be deleted, because hadoopFs.listFiles function will not list directories, it will only list files of the path.
   
   
   ### Does this PR introduce _any_ user-facing change?
   No.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1641: [CELEBORN-728] Celeborn won't clean remnant application directory on HDFS if worker is restarted

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1641:
URL: https://github.com/apache/incubator-celeborn/pull/1641#issuecomment-1611099766

   ## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1641?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#1641](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1641?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (b9f659a) into [branch-0.3](https://app.codecov.io/gh/apache/incubator-celeborn/commit/1241f093faea336d8742134a430896675ff33237?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1241f09) will **increase** coverage by `0.15%`.
   > The diff coverage is `0.00%`.
   
   ```diff
   @@              Coverage Diff               @@
   ##           branch-0.3    #1641      +/-   ##
   ==============================================
   + Coverage       46.01%   46.15%   +0.15%     
   ==============================================
     Files             161      161              
     Lines            9990     9994       +4     
     Branches          973      973              
   ==============================================
   + Hits             4596     4612      +16     
   + Misses           5092     5083       -9     
   + Partials          302      299       -3     
   ```
   
   
   | [Impacted Files](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1641?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...born/common/protocol/message/ControlMessages.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1641?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL3Byb3RvY29sL21lc3NhZ2UvQ29udHJvbE1lc3NhZ2VzLnNjYWxh) | `1.38% <0.00%> (-<0.01%)` | :arrow_down: |
   
   ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1641/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] waitinfuture closed pull request #1641: [CELEBORN-728] Celeborn won't clean remnant application directory on HDFS if worker is restarted

Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture closed pull request #1641: [CELEBORN-728] Celeborn won't clean remnant application directory on HDFS if worker is restarted
URL: https://github.com/apache/incubator-celeborn/pull/1641


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org