You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/12/14 14:30:58 UTC
[jira] [Commented] (BEAM-853) Force streaming execution on batch
pipelines for testing.
[ https://issues.apache.org/jira/browse/BEAM-853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15748467#comment-15748467 ]
ASF GitHub Bot commented on BEAM-853:
-------------------------------------
GitHub user amitsela opened a pull request:
https://github.com/apache/incubator-beam/pull/1614
[BEAM-853] Force streaming execution on batch pipelines for testing.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/amitsela/incubator-beam BEAM-853
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1614.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1614
----
commit 7b7fed35cc3119ba11cca076e60e8cb1d13836a1
Author: Sela <an...@paypal.com>
Date: 2016-12-14T10:20:08Z
Expose the adapted source.
commit e729db1a84c5c554a61b7a0a2db89fb0cf45f191
Author: Sela <an...@paypal.com>
Date: 2016-12-14T10:20:42Z
Force streaming execution, if set in PipelineOptions.
commit e2f9419810a581e82b703d90b00db71e040f806a
Author: Sela <an...@paypal.com>
Date: 2016-12-14T14:28:24Z
Added test.
----
> Force streaming execution on batch pipelines for testing.
> ---------------------------------------------------------
>
> Key: BEAM-853
> URL: https://issues.apache.org/jira/browse/BEAM-853
> Project: Beam
> Issue Type: Bug
> Components: runner-spark
> Reporter: Amit Sela
> Assignee: Amit Sela
>
> Beam's {{RunnableOnService}} tests for runners are written with bounded reads so the SparkRunner should force a streaming pipeline on an "all-batch" pipeline.
> Currently the runner will decide the translation (batch/streaming) according to the input PCollection boundness (in case of input, according to output).
> One way to overcome this would be to override this behaviour in {{TestSparkRunner}}.
> Another challenge is the implementation itself - we could clearly read the RDD and create a single-RDD-DStream of it (following RDDs will be empty) but this will miss the point of testing streaming pipelines both for testing the execution of {{Read.Unbounded}} and for testing across-microbatches (tests state management).
> Finally, we have to consider how this is going to play nicely with {{SplittableDoFn}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)