You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Yann Ylavic <yl...@gmail.com> on 2018/08/28 13:54:29 UTC
Re: svn commit: r1837599 - /httpd/httpd/branches/2.4.x/STATUS
On Tue, Aug 7, 2018 at 4:19 PM <rj...@apache.org> wrote:
>
> Author: rjung
> Date: Tue Aug 7 14:19:31 2018
> New Revision: 1837599
>
> URL: http://svn.apache.org/viewvc?rev=1837599&view=rev
> Log:
> Propose a few monitoring improvements.
>
> Modified:
> httpd/httpd/branches/2.4.x/STATUS
>
> Modified: httpd/httpd/branches/2.4.x/STATUS
> URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/STATUS?rev=1837599&r1=1837598&r2=1837599&view=diff
> ==============================================================================
> --- httpd/httpd/branches/2.4.x/STATUS (original)
> +++ httpd/httpd/branches/2.4.x/STATUS Tue Aug 7 14:19:31 2018
> @@ -200,6 +200,41 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
> 2.4.x patch: http://home.apache.org/~jim/patches/socache_redis.patch
> +1: jim,
>
> + *) mod_proxy: Improve the balancer member data shown
> + in mod_status when "ProxyStatus" is "On":
> + add "busy" count and show byte counts in auto
> + mode always in units of kilobytes.
> + trunk: http://svn.apache.org/r1837588
> + 2.4.x patch: svn merge -c 1837588 ^/httpd/httpd/trunk .
> + (adjust CHANGES)
> + +1: rjung
> +
> + *) mod_status: Complete the data shown for async
> + MPMs in "auto" mode. Added number of processes,
> + number of stopping processes and number
> + of busy and idle workers.
> + trunk: http://svn.apache.org/r1837589
> + 2.4.x patch: svn merge -c 1837589 ^/httpd/httpd/trunk .
> + (adjust CHANGES)
> + +1: rjung
> +
> + *) mod_status: Add cumulated response duration time
> + in milliseconds.
> + trunk: http://svn.apache.org/r1837590
> + 2.4.x patch: svn merge -c 1837590 ^/httpd/httpd/trunk .
> + (adjust CHANGES and include/ap_mmn.h)
> + +1: rjung
> +
> + *) mod_status: Cumulate CPU time of exited child
> + processes in the "cu" and "cs" values.
> + Add CPU time of the parent process to the
> + "c" and "s" values.
> + trunk: http://svn.apache.org/r1837595
> + 2.4.x patch: svn merge -c 1837595 ^/httpd/httpd/trunk .
> + (adjust CHANGES and include/ap_mmn.h)
> + +1: rjung
Those changes look fine (and great) to me, I wanted to +1 but I'm
wondering if they really belong in 2.4.x since the output of
mod_status is changed in a way that could break existing parsers.
I don't know the "policy" here...
Re: svn commit: r1837599 - /httpd/httpd/branches/2.4.x/STATUS
Posted by Rainer Jung <ra...@kippdata.de>.
Am 31.08.2018 um 20:30 schrieb Eric Covener:
>> So the question is probably whether Eric thinks keeping the HTML output
>> stable is more important than adding response duration info and proxy
>> busyness info. I'm open to any decision.
>
> I didn't mean I had any issue with the HTML change. I think it's OK too.
Thanks for the clarification. So I will proceed and commit.
Regards,
Rainer
Re: svn commit: r1837599 - /httpd/httpd/branches/2.4.x/STATUS
Posted by Eric Covener <co...@gmail.com>.
> So the question is probably whether Eric thinks keeping the HTML output
> stable is more important than adding response duration info and proxy
> busyness info. I'm open to any decision.
I didn't mean I had any issue with the HTML change. I think it's OK too.
Re: svn commit: r1837599 - /httpd/httpd/branches/2.4.x/STATUS
Posted by Rainer Jung <ra...@kippdata.de>.
Am 29.08.2018 um 05:45 schrieb Rainer Jung:
> Am 28.08.2018 um 15:54 schrieb Yann Ylavic:
>> On Tue, Aug 7, 2018 at 4:19 PM <rj...@apache.org> wrote:
>>> Log:
>>> Propose a few monitoring improvements.
>>
>> Those changes look fine (and great) to me, I wanted to +1 but I'm
>> wondering if they really belong in 2.4.x since the output of
>> mod_status is changed in a way that could break existing parsers.
>> I don't know the "policy" here...
>
> I have for now only applied the uncontroversial "auto" mode part of the
> accepted patches to make at least some progress.
>
> The "html" part is now back in STATUS (with adjusted smaller patches) to
> give some more time for feedback whether the HTML output format is
> allowed to change during a patch release (at least on a case by case
> basis).
>
> I have kept Jim's and your vote. Please adjust if you do not want the
> HTML changes to get applied as well.
I don't know how to proceed. I committed the uncontroversial auto part,
but for the HTML part, as a response to Yann's question whether it would
be OK to change the format in a patch release there were responses from
- Eric, saying changing auto is OK
- Jim responding with +1 to Eric's feedback, but who had also voted +1
on the complete change including HTML
- Yann, originally raising the question but then deciding to give +1 on
auto plus HTML
So the question is probably whether Eric thinks keeping the HTML output
stable is more important than adding response duration info and proxy
busyness info. I'm open to any decision.
IMHO auto is in reasonable shape since at least 2.4.16 (r1674659,
released July 2015) so automated monitoring should really switch there
(and tolerate new and unknown keys).
Regards,
Rainer
Re: svn commit: r1837599 - /httpd/httpd/branches/2.4.x/STATUS
Posted by Rainer Jung <ra...@kippdata.de>.
Am 28.08.2018 um 15:54 schrieb Yann Ylavic:
> On Tue, Aug 7, 2018 at 4:19 PM <rj...@apache.org> wrote:
>> Log:
>> Propose a few monitoring improvements.
>
> Those changes look fine (and great) to me, I wanted to +1 but I'm
> wondering if they really belong in 2.4.x since the output of
> mod_status is changed in a way that could break existing parsers.
> I don't know the "policy" here...
I have for now only applied the uncontroversial "auto" mode part of the
accepted patches to make at least some progress.
The "html" part is now back in STATUS (with adjusted smaller patches) to
give some more time for feedback whether the HTML output format is
allowed to change during a patch release (at least on a case by case basis).
I have kept Jim's and your vote. Please adjust if you do not want the
HTML changes to get applied as well.
Thanks and regards,
Rainer
Re: svn commit: r1837599 - /httpd/httpd/branches/2.4.x/STATUS
Posted by Jim Jagielski <ji...@jaguNET.com>.
+1
> On Aug 28, 2018, at 10:30 AM, Eric Covener <co...@gmail.com> wrote:
>
> On Tue, Aug 28, 2018 at 9:54 AM Yann Ylavic <yl...@gmail.com> wrote:
>>
>> On Tue, Aug 7, 2018 at 4:19 PM <rj...@apache.org> wrote:
>>>
>>> Author: rjung
>>> Date: Tue Aug 7 14:19:31 2018
>>> New Revision: 1837599
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1837599&view=rev
>>> Log:
>>> Propose a few monitoring improvements.
>>>
>>> Modified:
>>> httpd/httpd/branches/2.4.x/STATUS
>>>
>>> Modified: httpd/httpd/branches/2.4.x/STATUS
>>> URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/STATUS?rev=1837599&r1=1837598&r2=1837599&view=diff
>>> ==============================================================================
>>> --- httpd/httpd/branches/2.4.x/STATUS (original)
>>> +++ httpd/httpd/branches/2.4.x/STATUS Tue Aug 7 14:19:31 2018
>>> @@ -200,6 +200,41 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
>>> 2.4.x patch: http://home.apache.org/~jim/patches/socache_redis.patch
>>> +1: jim,
>>>
>>> + *) mod_proxy: Improve the balancer member data shown
>>> + in mod_status when "ProxyStatus" is "On":
>>> + add "busy" count and show byte counts in auto
>>> + mode always in units of kilobytes.
>>> + trunk: http://svn.apache.org/r1837588
>>> + 2.4.x patch: svn merge -c 1837588 ^/httpd/httpd/trunk .
>>> + (adjust CHANGES)
>>> + +1: rjung
>>> +
>>> + *) mod_status: Complete the data shown for async
>>> + MPMs in "auto" mode. Added number of processes,
>>> + number of stopping processes and number
>>> + of busy and idle workers.
>>> + trunk: http://svn.apache.org/r1837589
>>> + 2.4.x patch: svn merge -c 1837589 ^/httpd/httpd/trunk .
>>> + (adjust CHANGES)
>>> + +1: rjung
>>> +
>>> + *) mod_status: Add cumulated response duration time
>>> + in milliseconds.
>>> + trunk: http://svn.apache.org/r1837590
>>> + 2.4.x patch: svn merge -c 1837590 ^/httpd/httpd/trunk .
>>> + (adjust CHANGES and include/ap_mmn.h)
>>> + +1: rjung
>>> +
>>> + *) mod_status: Cumulate CPU time of exited child
>>> + processes in the "cu" and "cs" values.
>>> + Add CPU time of the parent process to the
>>> + "c" and "s" values.
>>> + trunk: http://svn.apache.org/r1837595
>>> + 2.4.x patch: svn merge -c 1837595 ^/httpd/httpd/trunk .
>>> + (adjust CHANGES and include/ap_mmn.h)
>>> + +1: rjung
>>
>> Those changes look fine (and great) to me, I wanted to +1 but I'm
>> wondering if they really belong in 2.4.x since the output of
>> mod_status is changed in a way that could break existing parsers.
>> I don't know the "policy" here...
>
> I think new keys in ?auto mode are OK.
Re: svn commit: r1837599 - /httpd/httpd/branches/2.4.x/STATUS
Posted by Eric Covener <co...@gmail.com>.
On Tue, Aug 28, 2018 at 9:54 AM Yann Ylavic <yl...@gmail.com> wrote:
>
> On Tue, Aug 7, 2018 at 4:19 PM <rj...@apache.org> wrote:
> >
> > Author: rjung
> > Date: Tue Aug 7 14:19:31 2018
> > New Revision: 1837599
> >
> > URL: http://svn.apache.org/viewvc?rev=1837599&view=rev
> > Log:
> > Propose a few monitoring improvements.
> >
> > Modified:
> > httpd/httpd/branches/2.4.x/STATUS
> >
> > Modified: httpd/httpd/branches/2.4.x/STATUS
> > URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/STATUS?rev=1837599&r1=1837598&r2=1837599&view=diff
> > ==============================================================================
> > --- httpd/httpd/branches/2.4.x/STATUS (original)
> > +++ httpd/httpd/branches/2.4.x/STATUS Tue Aug 7 14:19:31 2018
> > @@ -200,6 +200,41 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
> > 2.4.x patch: http://home.apache.org/~jim/patches/socache_redis.patch
> > +1: jim,
> >
> > + *) mod_proxy: Improve the balancer member data shown
> > + in mod_status when "ProxyStatus" is "On":
> > + add "busy" count and show byte counts in auto
> > + mode always in units of kilobytes.
> > + trunk: http://svn.apache.org/r1837588
> > + 2.4.x patch: svn merge -c 1837588 ^/httpd/httpd/trunk .
> > + (adjust CHANGES)
> > + +1: rjung
> > +
> > + *) mod_status: Complete the data shown for async
> > + MPMs in "auto" mode. Added number of processes,
> > + number of stopping processes and number
> > + of busy and idle workers.
> > + trunk: http://svn.apache.org/r1837589
> > + 2.4.x patch: svn merge -c 1837589 ^/httpd/httpd/trunk .
> > + (adjust CHANGES)
> > + +1: rjung
> > +
> > + *) mod_status: Add cumulated response duration time
> > + in milliseconds.
> > + trunk: http://svn.apache.org/r1837590
> > + 2.4.x patch: svn merge -c 1837590 ^/httpd/httpd/trunk .
> > + (adjust CHANGES and include/ap_mmn.h)
> > + +1: rjung
> > +
> > + *) mod_status: Cumulate CPU time of exited child
> > + processes in the "cu" and "cs" values.
> > + Add CPU time of the parent process to the
> > + "c" and "s" values.
> > + trunk: http://svn.apache.org/r1837595
> > + 2.4.x patch: svn merge -c 1837595 ^/httpd/httpd/trunk .
> > + (adjust CHANGES and include/ap_mmn.h)
> > + +1: rjung
>
> Those changes look fine (and great) to me, I wanted to +1 but I'm
> wondering if they really belong in 2.4.x since the output of
> mod_status is changed in a way that could break existing parsers.
> I don't know the "policy" here...
I think new keys in ?auto mode are OK.
Re: svn commit: r1837599 - /httpd/httpd/branches/2.4.x/STATUS
Posted by Yann Ylavic <yl...@gmail.com>.
Hi Rainer,
On Tue, Aug 28, 2018 at 4:30 PM Rainer Jung <ra...@kippdata.de> wrote:
>
> Hi Yann, I will try to comment inline per patch. Yes, that's always a
> difficult decision. I think for the "?auto" part it should be easy: it
> uses a line based key-value format, so adding new keys should be fine
> for nearly any parser. For the HTML based output the decision is more
> difficult.
As I said I like your patches, since there seems to be no objections
you got my votes ;)
Thanks!
Re: svn commit: r1837599 - /httpd/httpd/branches/2.4.x/STATUS
Posted by Rainer Jung <ra...@kippdata.de>.
Hi Yann, I will try to comment inline per patch. Yes, that's always a
difficult decision. I think for the "?auto" part it should be easy: it
uses a line based key-value format, so adding new keys should be fine
for nearly any parser. For the HTML based output the decision is more
difficult.
Am 28.08.2018 um 15:54 schrieb Yann Ylavic:
> Those changes look fine (and great) to me, I wanted to +1 but I'm
> wondering if they really belong in 2.4.x since the output of
> mod_status is changed in a way that could break existing parsers.
> I don't know the "policy" here...
> On Tue, Aug 7, 2018 at 4:19 PM <rj...@apache.org> wrote:
>>
>> Author: rjung
>> Date: Tue Aug 7 14:19:31 2018
>> New Revision: 1837599
>>
>> URL: http://svn.apache.org/viewvc?rev=1837599&view=rev
>> Log:
>> Propose a few monitoring improvements.
>>
>> Modified:
>> httpd/httpd/branches/2.4.x/STATUS
>>
>> Modified: httpd/httpd/branches/2.4.x/STATUS
>> URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/STATUS?rev=1837599&r1=1837598&r2=1837599&view=diff
>> ==============================================================================
>> --- httpd/httpd/branches/2.4.x/STATUS (original)
>> +++ httpd/httpd/branches/2.4.x/STATUS Tue Aug 7 14:19:31 2018
>> @@ -200,6 +200,41 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
>> 2.4.x patch: http://home.apache.org/~jim/patches/socache_redis.patch
>> +1: jim,
>>
>> + *) mod_proxy: Improve the balancer member data shown
>> + in mod_status when "ProxyStatus" is "On":
>> + add "busy" count and show byte counts in auto
>> + mode always in units of kilobytes.
>> + trunk: http://svn.apache.org/r1837588
>> + 2.4.x patch: svn merge -c 1837588 ^/httpd/httpd/trunk .
>> + (adjust CHANGES)
>> + +1: rjung
The first two hunks change the HTML output, the third only the auto
output. IMHO the change in the HTML output is so useful, that it the
format change should be OK. The added busy value is the most important
value to decide, whch of your backends is getting slow.
>> + *) mod_status: Complete the data shown for async
>> + MPMs in "auto" mode. Added number of processes,
>> + number of stopping processes and number
>> + of busy and idle workers.
>> + trunk: http://svn.apache.org/r1837589
>> + 2.4.x patch: svn merge -c 1837589 ^/httpd/httpd/trunk .
>> + (adjust CHANGES)
>> + +1: rjung
Only auto changes.
>> + *) mod_status: Add cumulated response duration time
>> + in milliseconds.
>> + trunk: http://svn.apache.org/r1837590
>> + 2.4.x patch: svn merge -c 1837590 ^/httpd/httpd/trunk .
>> + (adjust CHANGES and include/ap_mmn.h)
>> + +1: rjung
auto and HTML changes. The HTML change is for request duration, again a
pretty helpful value. I could drop it from the per slot table and only
keep it in the top part of the status page as separate new lines.
>> + *) mod_status: Cumulate CPU time of exited child
>> + processes in the "cu" and "cs" values.
>> + Add CPU time of the parent process to the
>> + "c" and "s" values.
>> + trunk: http://svn.apache.org/r1837595
>> + 2.4.x patch: svn merge -c 1837595 ^/httpd/httpd/trunk .
>> + (adjust CHANGES and include/ap_mmn.h)
>> + +1: rjung
This doesn't change the output format, but fixes the wrong (and mostly
useless) CPU values we do provide currently.
Regards,
Rainer