[GitHub] ankkhedia opened a new pull request #12358: Fix flaky test : test_ndarray.test_order

[GitBox <gi...@apache.org>]

ankkhedia opened a new pull request #12358:  Fix flaky test : test_ndarray.test_order
URL: https://github.com/apache/incubator-mxnet/pull/12358
 
 
   ## Description ##
    Fix flaky test: test_ndarray.test_order. Tracked in #12310
   
   The test uses np.int16 which is not a supported dtype for ndarray.
   Also, conversion of np array to ndarray defaults to float32 in destination ndarray even though the dtype of source could be anything leading to failure of unites due to loss of precision in some cases.
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [x] All changes have test coverage:
   - [x] Code is well-documented: 
   - [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   
   --> Removed tests for np.int16
   --> Instead of using default dtype for converting arrays , used the type from source array to convert to target array.
   
   Ran the test with changes for 5000 runs for different seeds and verified it.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services