You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@johnzon.apache.org by Daniel Cunha <da...@gmail.com> on 2015/03/12 21:48:04 UTC
Changes in Numbers Json implemetations
Hi folks,
https://github.com/apache/incubator-johnzon/compare/master...danielsoro:numbers?expand=1
I have this change in johnzon, maybe this patch can be apply.
patch attached.
--
Best regard,
Daniel Cunha (soro)
Re: Changes in Numbers Json implemetations
Posted by Daniel Cunha <da...@gmail.com>.
Hi Hendrik,
Nice.. that will help me. :)
Thank you!
On Fri, Mar 13, 2015 at 5:13 PM, Hendrik Dev <he...@gmail.com> wrote:
> Hi Daniel,
>
> thanks for the patch. We have an unofficial benchmark suite which can
> be found here: https://github.com/salyh/jsr353-benchmark
> It would be great if you could benchmark your patch against current
> master to make sure that there are no perf implications.
>
> Thanks
> Hendrik
>
>
>
> On Fri, Mar 13, 2015 at 3:12 PM, Romain Manni-Bucau
> <rm...@gmail.com> wrote:
>> Better but what about perf - was my main point?
>> Le 13 mars 2015 15:03, "Daniel Cunha" <da...@gmail.com> a écrit :
>>
>>> Hi Romain,
>>>
>>>
>>> https://github.com/apache/incubator-johnzon/compare/master...danielsoro:numbers?expand=1
>>> WDYT!?
>>>
>>> patch attached.
>>>
>>>
>>> On Thu, Mar 12, 2015 at 6:37 PM, Romain Manni-Bucau
>>> <rm...@gmail.com> wrote:
>>> > Hmm seems you do too much conversions in some cases (big decimal for
>>> > instance)
>>> >
>>> > That said i m not sure it brings (readability) more than it destroy
>>> (perf).
>>> > Any figures to proove me i am wrong?
>>> > Le 12 mars 2015 21:50, "Daniel Cunha" <da...@gmail.com> a écrit :
>>> >
>>> >> Hi folks,
>>> >>
>>> >>
>>> >>
>>> https://github.com/apache/incubator-johnzon/compare/master...danielsoro:numbers?expand=1
>>> >>
>>> >> I have this change in johnzon, maybe this patch can be apply.
>>> >> patch attached.
>>> >>
>>> >> --
>>> >> Best regard,
>>> >> Daniel Cunha (soro)
>>> >>
>>>
>>>
>>>
>>> --
>>> Best regard,
>>> Daniel Cunha (soro)
>>>
>
>
>
> --
> Hendrik Saly (salyh, hendrikdev22)
> @hendrikdev22
> PGP: 0x22D7F6EC
--
Best regard,
Daniel Cunha (soro)
Re: Changes in Numbers Json implemetations
Posted by Hendrik Dev <he...@gmail.com>.
Hi Daniel,
thanks for the patch. We have an unofficial benchmark suite which can
be found here: https://github.com/salyh/jsr353-benchmark
It would be great if you could benchmark your patch against current
master to make sure that there are no perf implications.
Thanks
Hendrik
On Fri, Mar 13, 2015 at 3:12 PM, Romain Manni-Bucau
<rm...@gmail.com> wrote:
> Better but what about perf - was my main point?
> Le 13 mars 2015 15:03, "Daniel Cunha" <da...@gmail.com> a écrit :
>
>> Hi Romain,
>>
>>
>> https://github.com/apache/incubator-johnzon/compare/master...danielsoro:numbers?expand=1
>> WDYT!?
>>
>> patch attached.
>>
>>
>> On Thu, Mar 12, 2015 at 6:37 PM, Romain Manni-Bucau
>> <rm...@gmail.com> wrote:
>> > Hmm seems you do too much conversions in some cases (big decimal for
>> > instance)
>> >
>> > That said i m not sure it brings (readability) more than it destroy
>> (perf).
>> > Any figures to proove me i am wrong?
>> > Le 12 mars 2015 21:50, "Daniel Cunha" <da...@gmail.com> a écrit :
>> >
>> >> Hi folks,
>> >>
>> >>
>> >>
>> https://github.com/apache/incubator-johnzon/compare/master...danielsoro:numbers?expand=1
>> >>
>> >> I have this change in johnzon, maybe this patch can be apply.
>> >> patch attached.
>> >>
>> >> --
>> >> Best regard,
>> >> Daniel Cunha (soro)
>> >>
>>
>>
>>
>> --
>> Best regard,
>> Daniel Cunha (soro)
>>
--
Hendrik Saly (salyh, hendrikdev22)
@hendrikdev22
PGP: 0x22D7F6EC
Re: Changes in Numbers Json implemetations
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Better but what about perf - was my main point?
Le 13 mars 2015 15:03, "Daniel Cunha" <da...@gmail.com> a écrit :
> Hi Romain,
>
>
> https://github.com/apache/incubator-johnzon/compare/master...danielsoro:numbers?expand=1
> WDYT!?
>
> patch attached.
>
>
> On Thu, Mar 12, 2015 at 6:37 PM, Romain Manni-Bucau
> <rm...@gmail.com> wrote:
> > Hmm seems you do too much conversions in some cases (big decimal for
> > instance)
> >
> > That said i m not sure it brings (readability) more than it destroy
> (perf).
> > Any figures to proove me i am wrong?
> > Le 12 mars 2015 21:50, "Daniel Cunha" <da...@gmail.com> a écrit :
> >
> >> Hi folks,
> >>
> >>
> >>
> https://github.com/apache/incubator-johnzon/compare/master...danielsoro:numbers?expand=1
> >>
> >> I have this change in johnzon, maybe this patch can be apply.
> >> patch attached.
> >>
> >> --
> >> Best regard,
> >> Daniel Cunha (soro)
> >>
>
>
>
> --
> Best regard,
> Daniel Cunha (soro)
>
Re: Changes in Numbers Json implemetations
Posted by Daniel Cunha <da...@gmail.com>.
Hi Romain,
https://github.com/apache/incubator-johnzon/compare/master...danielsoro:numbers?expand=1
WDYT!?
patch attached.
On Thu, Mar 12, 2015 at 6:37 PM, Romain Manni-Bucau
<rm...@gmail.com> wrote:
> Hmm seems you do too much conversions in some cases (big decimal for
> instance)
>
> That said i m not sure it brings (readability) more than it destroy (perf).
> Any figures to proove me i am wrong?
> Le 12 mars 2015 21:50, "Daniel Cunha" <da...@gmail.com> a écrit :
>
>> Hi folks,
>>
>>
>> https://github.com/apache/incubator-johnzon/compare/master...danielsoro:numbers?expand=1
>>
>> I have this change in johnzon, maybe this patch can be apply.
>> patch attached.
>>
>> --
>> Best regard,
>> Daniel Cunha (soro)
>>
--
Best regard,
Daniel Cunha (soro)
Re: Changes in Numbers Json implemetations
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Hmm seems you do too much conversions in some cases (big decimal for
instance)
That said i m not sure it brings (readability) more than it destroy (perf).
Any figures to proove me i am wrong?
Le 12 mars 2015 21:50, "Daniel Cunha" <da...@gmail.com> a écrit :
> Hi folks,
>
>
> https://github.com/apache/incubator-johnzon/compare/master...danielsoro:numbers?expand=1
>
> I have this change in johnzon, maybe this patch can be apply.
> patch attached.
>
> --
> Best regard,
> Daniel Cunha (soro)
>