You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/15 05:40:38 UTC

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #9122: ARROW-10299: [Rust] Use IPC Metadata V5 as default

jorgecarleitao commented on a change in pull request #9122:
URL: https://github.com/apache/arrow/pull/9122#discussion_r557873579



##########
File path: rust/arrow/src/array/array_struct.rs
##########
@@ -69,6 +69,9 @@ impl StructArray {
     }
 
     /// Return child array whose field name equals to column_name
+    ///
+    /// Note: The Arrow specification allows for duplicate field names, and in such

Review comment:
       We had a similar discussion on DataFusion for `RecordBatch` a while back. We now just refuse duplicated column names, as it offers a much, much simpler way of dealing with columns via column names.
   
   However, sometimes people have to parse files with equal column names, which means that arrow somehow has to support them on `RecordBatch`.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org