You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/20 14:13:47 UTC
[GitHub] [flink] pnowojski opened a new pull request #18424: [FLINK-24439] Introduce CoordinatorStore
pnowojski opened a new pull request #18424:
URL: https://github.com/apache/flink/pull/18424
In order to allow `SourceCoordinators`s from different `Source`s (for example two different Kafka sources, or Kafka and Kinesis) to align watermarks, they have to be able to exchange information/aggregate watermarks from those different Sources. To enable this, we need to provide some CoordinatorStore concept, that would be a thread safe singleton.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (**yes** / no)
- If yes, how is the feature documented? (not applicable / docs / **JavaDocs** / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18424: [FLINK-24439][source] Introduce CoordinatorStore
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18424:
URL: https://github.com/apache/flink/pull/18424#issuecomment-1017555030
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e14029b31fa30838385ccf84278509b905fb6f53",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29804",
"triggerID" : "e14029b31fa30838385ccf84278509b905fb6f53",
"triggerType" : "PUSH"
}, {
"hash" : "4660f755455da1645e5a2a69f1f9f576648ff244",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30775",
"triggerID" : "4660f755455da1645e5a2a69f1f9f576648ff244",
"triggerType" : "PUSH"
}, {
"hash" : "d3dcfcffac98667f84535dff9d14451f8a17b78e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d3dcfcffac98667f84535dff9d14451f8a17b78e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e14029b31fa30838385ccf84278509b905fb6f53 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29804)
* 4660f755455da1645e5a2a69f1f9f576648ff244 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30775)
* d3dcfcffac98667f84535dff9d14451f8a17b78e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18424: [FLINK-24439][source] Introduce CoordinatorStore
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18424:
URL: https://github.com/apache/flink/pull/18424#issuecomment-1017555030
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e14029b31fa30838385ccf84278509b905fb6f53",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29804",
"triggerID" : "e14029b31fa30838385ccf84278509b905fb6f53",
"triggerType" : "PUSH"
}, {
"hash" : "4660f755455da1645e5a2a69f1f9f576648ff244",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30775",
"triggerID" : "4660f755455da1645e5a2a69f1f9f576648ff244",
"triggerType" : "PUSH"
}, {
"hash" : "d3dcfcffac98667f84535dff9d14451f8a17b78e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30780",
"triggerID" : "d3dcfcffac98667f84535dff9d14451f8a17b78e",
"triggerType" : "PUSH"
}, {
"hash" : "68007393428b538f5e8f28c37b0159f93251ea57",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30842",
"triggerID" : "68007393428b538f5e8f28c37b0159f93251ea57",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 68007393428b538f5e8f28c37b0159f93251ea57 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30842)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18424: [FLINK-24439][source] Introduce CoordinatorStore
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18424:
URL: https://github.com/apache/flink/pull/18424#issuecomment-1017555030
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e14029b31fa30838385ccf84278509b905fb6f53",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29804",
"triggerID" : "e14029b31fa30838385ccf84278509b905fb6f53",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e14029b31fa30838385ccf84278509b905fb6f53 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29804)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18424: [FLINK-24439][source] Introduce CoordinatorStore
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18424:
URL: https://github.com/apache/flink/pull/18424#issuecomment-1017555030
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e14029b31fa30838385ccf84278509b905fb6f53",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29804",
"triggerID" : "e14029b31fa30838385ccf84278509b905fb6f53",
"triggerType" : "PUSH"
}, {
"hash" : "4660f755455da1645e5a2a69f1f9f576648ff244",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4660f755455da1645e5a2a69f1f9f576648ff244",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e14029b31fa30838385ccf84278509b905fb6f53 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29804)
* 4660f755455da1645e5a2a69f1f9f576648ff244 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18424: [FLINK-24439][source] Introduce CoordinatorStore
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18424:
URL: https://github.com/apache/flink/pull/18424#issuecomment-1017555030
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e14029b31fa30838385ccf84278509b905fb6f53",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29804",
"triggerID" : "e14029b31fa30838385ccf84278509b905fb6f53",
"triggerType" : "PUSH"
}, {
"hash" : "4660f755455da1645e5a2a69f1f9f576648ff244",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30775",
"triggerID" : "4660f755455da1645e5a2a69f1f9f576648ff244",
"triggerType" : "PUSH"
}, {
"hash" : "d3dcfcffac98667f84535dff9d14451f8a17b78e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30780",
"triggerID" : "d3dcfcffac98667f84535dff9d14451f8a17b78e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4660f755455da1645e5a2a69f1f9f576648ff244 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30775)
* d3dcfcffac98667f84535dff9d14451f8a17b78e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30780)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18424: [FLINK-24439][source] Introduce CoordinatorStore
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18424:
URL: https://github.com/apache/flink/pull/18424#issuecomment-1017555030
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e14029b31fa30838385ccf84278509b905fb6f53",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29804",
"triggerID" : "e14029b31fa30838385ccf84278509b905fb6f53",
"triggerType" : "PUSH"
}, {
"hash" : "4660f755455da1645e5a2a69f1f9f576648ff244",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30775",
"triggerID" : "4660f755455da1645e5a2a69f1f9f576648ff244",
"triggerType" : "PUSH"
}, {
"hash" : "d3dcfcffac98667f84535dff9d14451f8a17b78e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d3dcfcffac98667f84535dff9d14451f8a17b78e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e14029b31fa30838385ccf84278509b905fb6f53 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29804)
* 4660f755455da1645e5a2a69f1f9f576648ff244 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30775)
* d3dcfcffac98667f84535dff9d14451f8a17b78e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18424: [FLINK-24439][source] Introduce CoordinatorStore
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18424:
URL: https://github.com/apache/flink/pull/18424#issuecomment-1017555030
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e14029b31fa30838385ccf84278509b905fb6f53",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29804",
"triggerID" : "e14029b31fa30838385ccf84278509b905fb6f53",
"triggerType" : "PUSH"
}, {
"hash" : "4660f755455da1645e5a2a69f1f9f576648ff244",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30775",
"triggerID" : "4660f755455da1645e5a2a69f1f9f576648ff244",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e14029b31fa30838385ccf84278509b905fb6f53 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29804)
* 4660f755455da1645e5a2a69f1f9f576648ff244 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30775)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18424: [FLINK-24439][source] Introduce CoordinatorStore
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18424:
URL: https://github.com/apache/flink/pull/18424#issuecomment-1017555030
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e14029b31fa30838385ccf84278509b905fb6f53",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29804",
"triggerID" : "e14029b31fa30838385ccf84278509b905fb6f53",
"triggerType" : "PUSH"
}, {
"hash" : "4660f755455da1645e5a2a69f1f9f576648ff244",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30775",
"triggerID" : "4660f755455da1645e5a2a69f1f9f576648ff244",
"triggerType" : "PUSH"
}, {
"hash" : "d3dcfcffac98667f84535dff9d14451f8a17b78e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30780",
"triggerID" : "d3dcfcffac98667f84535dff9d14451f8a17b78e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e14029b31fa30838385ccf84278509b905fb6f53 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29804)
* 4660f755455da1645e5a2a69f1f9f576648ff244 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30775)
* d3dcfcffac98667f84535dff9d14451f8a17b78e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30780)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on a change in pull request #18424: [FLINK-24439][source] Introduce CoordinatorStore
Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #18424:
URL: https://github.com/apache/flink/pull/18424#discussion_r797639026
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/operators/coordination/CoordinatorStore.java
##########
@@ -0,0 +1,60 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package org.apache.flink.runtime.operators.coordination;
+
+import org.apache.flink.annotation.Internal;
+
+import javax.annotation.concurrent.ThreadSafe;
+
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.function.BiFunction;
+import java.util.function.Function;
+
+/**
+ * {@link CoordinatorStore} can be used for sharing some information among {@link
+ * OperatorCoordinator} instances. Motivating example is/was combining/aggregating latest watermark
+ * emitted by different sources in order to do the watermark alignment.
+ */
+@ThreadSafe
+@Internal
+public class CoordinatorStore {
Review comment:
This should be an interface.
EDIT: What I mean we should have an interface like that which is returned from the `OperatorCoordinator` interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18424: [FLINK-24439][source] Introduce CoordinatorStore
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18424:
URL: https://github.com/apache/flink/pull/18424#issuecomment-1017555030
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e14029b31fa30838385ccf84278509b905fb6f53",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29804",
"triggerID" : "e14029b31fa30838385ccf84278509b905fb6f53",
"triggerType" : "PUSH"
}, {
"hash" : "4660f755455da1645e5a2a69f1f9f576648ff244",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30775",
"triggerID" : "4660f755455da1645e5a2a69f1f9f576648ff244",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e14029b31fa30838385ccf84278509b905fb6f53 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29804)
* 4660f755455da1645e5a2a69f1f9f576648ff244 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30775)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18424: [FLINK-24439][source] Introduce CoordinatorStore
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18424:
URL: https://github.com/apache/flink/pull/18424#issuecomment-1017555030
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e14029b31fa30838385ccf84278509b905fb6f53",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29804",
"triggerID" : "e14029b31fa30838385ccf84278509b905fb6f53",
"triggerType" : "PUSH"
}, {
"hash" : "4660f755455da1645e5a2a69f1f9f576648ff244",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30775",
"triggerID" : "4660f755455da1645e5a2a69f1f9f576648ff244",
"triggerType" : "PUSH"
}, {
"hash" : "d3dcfcffac98667f84535dff9d14451f8a17b78e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30780",
"triggerID" : "d3dcfcffac98667f84535dff9d14451f8a17b78e",
"triggerType" : "PUSH"
}, {
"hash" : "68007393428b538f5e8f28c37b0159f93251ea57",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30842",
"triggerID" : "68007393428b538f5e8f28c37b0159f93251ea57",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d3dcfcffac98667f84535dff9d14451f8a17b78e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30780)
* 68007393428b538f5e8f28c37b0159f93251ea57 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30842)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18424: [FLINK-24439][source] Introduce CoordinatorStore
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18424:
URL: https://github.com/apache/flink/pull/18424#issuecomment-1017555030
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e14029b31fa30838385ccf84278509b905fb6f53",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29804",
"triggerID" : "e14029b31fa30838385ccf84278509b905fb6f53",
"triggerType" : "PUSH"
}, {
"hash" : "4660f755455da1645e5a2a69f1f9f576648ff244",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30775",
"triggerID" : "4660f755455da1645e5a2a69f1f9f576648ff244",
"triggerType" : "PUSH"
}, {
"hash" : "d3dcfcffac98667f84535dff9d14451f8a17b78e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d3dcfcffac98667f84535dff9d14451f8a17b78e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e14029b31fa30838385ccf84278509b905fb6f53 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29804)
* 4660f755455da1645e5a2a69f1f9f576648ff244 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30775)
* d3dcfcffac98667f84535dff9d14451f8a17b78e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18424: [FLINK-24439][source] Introduce CoordinatorStore
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18424:
URL: https://github.com/apache/flink/pull/18424#issuecomment-1017555030
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e14029b31fa30838385ccf84278509b905fb6f53",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29804",
"triggerID" : "e14029b31fa30838385ccf84278509b905fb6f53",
"triggerType" : "PUSH"
}, {
"hash" : "4660f755455da1645e5a2a69f1f9f576648ff244",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30775",
"triggerID" : "4660f755455da1645e5a2a69f1f9f576648ff244",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e14029b31fa30838385ccf84278509b905fb6f53 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29804)
* 4660f755455da1645e5a2a69f1f9f576648ff244 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30775)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18424: [FLINK-24439][source] Introduce CoordinatorStore
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18424:
URL: https://github.com/apache/flink/pull/18424#issuecomment-1017555030
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e14029b31fa30838385ccf84278509b905fb6f53",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29804",
"triggerID" : "e14029b31fa30838385ccf84278509b905fb6f53",
"triggerType" : "PUSH"
}, {
"hash" : "4660f755455da1645e5a2a69f1f9f576648ff244",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30775",
"triggerID" : "4660f755455da1645e5a2a69f1f9f576648ff244",
"triggerType" : "PUSH"
}, {
"hash" : "d3dcfcffac98667f84535dff9d14451f8a17b78e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d3dcfcffac98667f84535dff9d14451f8a17b78e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e14029b31fa30838385ccf84278509b905fb6f53 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29804)
* 4660f755455da1645e5a2a69f1f9f576648ff244 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30775)
* d3dcfcffac98667f84535dff9d14451f8a17b78e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski merged pull request #18424: [FLINK-24439][source] Introduce CoordinatorStore
Posted by GitBox <gi...@apache.org>.
pnowojski merged pull request #18424:
URL: https://github.com/apache/flink/pull/18424
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18424: [FLINK-24439][source] Introduce CoordinatorStore
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18424:
URL: https://github.com/apache/flink/pull/18424#issuecomment-1017555030
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e14029b31fa30838385ccf84278509b905fb6f53",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29804",
"triggerID" : "e14029b31fa30838385ccf84278509b905fb6f53",
"triggerType" : "PUSH"
}, {
"hash" : "4660f755455da1645e5a2a69f1f9f576648ff244",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30775",
"triggerID" : "4660f755455da1645e5a2a69f1f9f576648ff244",
"triggerType" : "PUSH"
}, {
"hash" : "d3dcfcffac98667f84535dff9d14451f8a17b78e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d3dcfcffac98667f84535dff9d14451f8a17b78e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e14029b31fa30838385ccf84278509b905fb6f53 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29804)
* 4660f755455da1645e5a2a69f1f9f576648ff244 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30775)
* d3dcfcffac98667f84535dff9d14451f8a17b78e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18424: [FLINK-24439][source] Introduce CoordinatorStore
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18424:
URL: https://github.com/apache/flink/pull/18424#issuecomment-1017555030
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e14029b31fa30838385ccf84278509b905fb6f53",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29804",
"triggerID" : "e14029b31fa30838385ccf84278509b905fb6f53",
"triggerType" : "PUSH"
}, {
"hash" : "4660f755455da1645e5a2a69f1f9f576648ff244",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30775",
"triggerID" : "4660f755455da1645e5a2a69f1f9f576648ff244",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e14029b31fa30838385ccf84278509b905fb6f53 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29804)
* 4660f755455da1645e5a2a69f1f9f576648ff244 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30775)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18424: [FLINK-24439][source] Introduce CoordinatorStore
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18424:
URL: https://github.com/apache/flink/pull/18424#issuecomment-1017547261
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 03d5a67f8dac2cffbfe4ddb011ab574c630d2cd9 (Thu Jan 20 14:17:50 UTC 2022)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18424: [FLINK-24439][source] Introduce CoordinatorStore
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18424:
URL: https://github.com/apache/flink/pull/18424#issuecomment-1017555030
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e14029b31fa30838385ccf84278509b905fb6f53",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e14029b31fa30838385ccf84278509b905fb6f53",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e14029b31fa30838385ccf84278509b905fb6f53 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18424: [FLINK-24439][source] Introduce CoordinatorStore
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18424:
URL: https://github.com/apache/flink/pull/18424#issuecomment-1017555030
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e14029b31fa30838385ccf84278509b905fb6f53",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29804",
"triggerID" : "e14029b31fa30838385ccf84278509b905fb6f53",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e14029b31fa30838385ccf84278509b905fb6f53 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29804)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18424: [FLINK-24439][source] Introduce CoordinatorStore
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18424:
URL: https://github.com/apache/flink/pull/18424#issuecomment-1017555030
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e14029b31fa30838385ccf84278509b905fb6f53",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29804",
"triggerID" : "e14029b31fa30838385ccf84278509b905fb6f53",
"triggerType" : "PUSH"
}, {
"hash" : "4660f755455da1645e5a2a69f1f9f576648ff244",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30775",
"triggerID" : "4660f755455da1645e5a2a69f1f9f576648ff244",
"triggerType" : "PUSH"
}, {
"hash" : "d3dcfcffac98667f84535dff9d14451f8a17b78e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30780",
"triggerID" : "d3dcfcffac98667f84535dff9d14451f8a17b78e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d3dcfcffac98667f84535dff9d14451f8a17b78e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30780)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #18424: [FLINK-24439][source] Introduce CoordinatorStore
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #18424:
URL: https://github.com/apache/flink/pull/18424#discussion_r799515994
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/operators/coordination/CoordinatorStore.java
##########
@@ -0,0 +1,60 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package org.apache.flink.runtime.operators.coordination;
+
+import org.apache.flink.annotation.Internal;
+
+import javax.annotation.concurrent.ThreadSafe;
+
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.function.BiFunction;
+import java.util.function.Function;
+
+/**
+ * {@link CoordinatorStore} can be used for sharing some information among {@link
+ * OperatorCoordinator} instances. Motivating example is/was combining/aggregating latest watermark
+ * emitted by different sources in order to do the watermark alignment.
+ */
+@ThreadSafe
+@Internal
+public class CoordinatorStore {
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18424: [FLINK-24439][source] Introduce CoordinatorStore
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18424:
URL: https://github.com/apache/flink/pull/18424#issuecomment-1017555030
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e14029b31fa30838385ccf84278509b905fb6f53",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29804",
"triggerID" : "e14029b31fa30838385ccf84278509b905fb6f53",
"triggerType" : "PUSH"
}, {
"hash" : "4660f755455da1645e5a2a69f1f9f576648ff244",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30775",
"triggerID" : "4660f755455da1645e5a2a69f1f9f576648ff244",
"triggerType" : "PUSH"
}, {
"hash" : "d3dcfcffac98667f84535dff9d14451f8a17b78e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30780",
"triggerID" : "d3dcfcffac98667f84535dff9d14451f8a17b78e",
"triggerType" : "PUSH"
}, {
"hash" : "68007393428b538f5e8f28c37b0159f93251ea57",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "68007393428b538f5e8f28c37b0159f93251ea57",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d3dcfcffac98667f84535dff9d14451f8a17b78e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30780)
* 68007393428b538f5e8f28c37b0159f93251ea57 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on a change in pull request #18424: [FLINK-24439][source] Introduce CoordinatorStore
Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #18424:
URL: https://github.com/apache/flink/pull/18424#discussion_r797639026
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/operators/coordination/CoordinatorStore.java
##########
@@ -0,0 +1,60 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package org.apache.flink.runtime.operators.coordination;
+
+import org.apache.flink.annotation.Internal;
+
+import javax.annotation.concurrent.ThreadSafe;
+
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.function.BiFunction;
+import java.util.function.Function;
+
+/**
+ * {@link CoordinatorStore} can be used for sharing some information among {@link
+ * OperatorCoordinator} instances. Motivating example is/was combining/aggregating latest watermark
+ * emitted by different sources in order to do the watermark alignment.
+ */
+@ThreadSafe
+@Internal
+public class CoordinatorStore {
Review comment:
This should be an interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org