You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/10/14 16:12:07 UTC

[GitHub] [maven-plugin-tools] michael-o commented on a diff in pull request #150: [MPLUGIN-391] Remove examples with scripting

michael-o commented on code in PR #150:
URL: https://github.com/apache/maven-plugin-tools/pull/150#discussion_r995923407


##########
src/site/site.xml:
##########
@@ -19,8 +19,8 @@ specific language governing permissions and limitations
 under the License.
 -->
 
-<project xmlns="https://maven.apache.org/DECORATION/1.8.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-  xsi:schemaLocation="https://maven.apache.org/DECORATION/1.8.0 http://maven.apache.org/xsd/decoration-1.8.0.xsd">
+<project xmlns="http://maven.apache.org/DECORATION/1.8.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+  xsi:schemaLocation="http://maven.apache.org/DECORATION/1.8.0 https://maven.apache.org/xsd/decoration-1.8.0.xsd">

Review Comment:
   This one is best :-D



##########
src/site/xdoc/index.xml:
##########
@@ -54,11 +53,11 @@
           <area shape="rect" coords="514,95,759,131"  alt="plugin-tools-generators"  href="./maven-plugin-tools-generators"/>
           <area shape="rect" coords="44,263,570,432"  alt="maven-script"             href="./maven-script"/>
           <area shape="rect" coords="340,438,529,474" alt="maven-plugin-api"         href="/ref/current/maven-plugin-api/"/>
-          <area shape="rect" coords="510,154,582,190" alt="qdox"                     href="http://qdox.codehaus.org/"/>
-          <area shape="rect" coords="510,212,583,248" alt="asm"                      href="http://asm.ow2.org/"/>
+          <area shape="rect" coords="510,154,582,190" alt="qdox"                     href="https://github.com/paul-hammant/qdox"/>
+          <area shape="rect" coords="510,212,583,248" alt="asm"                      href="https://asm.ow2.org/"/>
           <area shape="rect" coords="656,134,747,169" alt="Doxia"                    href="/doxia/"/>
           <area shape="rect" coords="599,271,715,306" alt="Beanshell"                href="http://www.beanshell.org/"/>
-          <area shape="rect" coords="600,329,670,366" alt="Ant"                      href="http://ant.apache.maven/"/>
+          <area shape="rect" coords="600,329,670,366" alt="Ant"                      href="https://ant.apache.org/"/>

Review Comment:
   That is even better.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org