[GitHub] [james-project] glennosss commented on a change in pull request #929: JAMES-3715 Several Netty 4 fixes and improvements to make starting and managing netty servers easier

[GitBox <gi...@apache.org>]

glennosss commented on a change in pull request #929:
URL: https://github.com/apache/james-project/pull/929#discussion_r832970016



##########
File path: protocols/netty/src/main/java/org/apache/james/protocols/netty/AbstractAsyncServer.java
##########
@@ -93,7 +93,7 @@ public synchronized void bind() throws Exception {
         ServerBootstrap bootstrap = new ServerBootstrap();
         bootstrap.channel(NioServerSocketChannel.class);
 
-        bossGroup = new NioEventLoopGroup(NamedThreadFactory.withName(jmxName + "-boss"));
+        bossGroup = new NioEventLoopGroup(2, NamedThreadFactory.withName(jmxName + "-boss"));

Review comment:
       FYI These types of hard coded thread pool sizes are a big part of what this pull request is trying to fix.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org