You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/11/04 11:37:43 UTC
[GitHub] [superset] kpretty opened a new pull request, #22036: fix:(translation)greatly optimize Chinese translation
kpretty opened a new pull request, #22036:
URL: https://github.com/apache/superset/pull/22036
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Almost completed the Chineseization work visible on the page
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<img width="1387" alt="Snipaste_2022-11-04_19-32-49" src="https://user-images.githubusercontent.com/77819741/199962915-74377fba-f652-4c5c-a10e-8777f89daca0.png">
<img width="1430" alt="image" src="https://user-images.githubusercontent.com/77819741/199963236-ad694826-c2b2-4336-9fcb-1750633662fb.png">
Add additional translations
<img width="899" alt="image" src="https://user-images.githubusercontent.com/77819741/199963659-aeb74b5e-4134-4235-989a-8d9d55288f7a.png">
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie merged pull request #22036: fix(i18n): greatly optimize Chinese translation
Posted by "zhaoyongjie (via GitHub)" <gi...@apache.org>.
zhaoyongjie merged PR #22036:
URL: https://github.com/apache/superset/pull/22036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #22036: fix(i18n): greatly optimize Chinese translation
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #22036:
URL: https://github.com/apache/superset/pull/22036#issuecomment-1409418822
@ktmud @zhaoyongjie @stephenLYZ @jinghua-qa are any of you (or anyone else fitting that I'm not thinking of here) able to validate/review this PR? I'm afraid I don't have the required language skills.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #22036: fix(i18n): greatly optimize Chinese translation
Posted by GitBox <gi...@apache.org>.
rusackas commented on PR #22036:
URL: https://github.com/apache/superset/pull/22036#issuecomment-1355268301
Thanks for the PR! Something seems stuck with CI here, and the usual restart buttons aren't working, so I'm going to close/reopen it to kickstart the process 🤞
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas closed pull request #22036: fix(i18n): greatly optimize Chinese translation
Posted by GitBox <gi...@apache.org>.
rusackas closed pull request #22036: fix(i18n): greatly optimize Chinese translation
URL: https://github.com/apache/superset/pull/22036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org