You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/10 12:59:18 UTC
[GitHub] [flink] docete opened a new pull request #10828: [FLINK-15460][JDBC] planner dependencies won't be necessary for JDBC …
docete opened a new pull request #10828: [FLINK-15460][JDBC] planner dependencies won't be necessary for JDBC …
URL: https://github.com/apache/flink/pull/10828
…connector
## What is the purpose of the change
jdbc connector code should not depend on planner now. Only testing code depend on them. This PR removes planner dependencies from JDBC connector by changing the scope to test.
## Brief change log
- 2715875 removes planner dependencies from JDBC connector by changing the scope to test
## Verifying this change
This change is a trivial rework without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (**yes** / no)
- If yes, how is the feature documented? (not applicable / docs / **JavaDocs** / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10828: [FLINK-15460][JDBC] planner dependencies won't be necessary for JDBC …
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10828: [FLINK-15460][JDBC] planner dependencies won't be necessary for JDBC …
URL: https://github.com/apache/flink/pull/10828#issuecomment-573039067
<!--
Meta data
Hash:2715875b652966235103eac77e95f1e4bc345c73 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:2715875b652966235103eac77e95f1e4bc345c73
-->
## CI report:
* 2715875b652966235103eac77e95f1e4bc345c73 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10828: [FLINK-15460][JDBC] planner dependencies won't be necessary for JDBC …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10828: [FLINK-15460][JDBC] planner dependencies won't be necessary for JDBC …
URL: https://github.com/apache/flink/pull/10828#issuecomment-573039067
<!--
Meta data
Hash:2715875b652966235103eac77e95f1e4bc345c73 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4258 TriggerType:PUSH TriggerID:2715875b652966235103eac77e95f1e4bc345c73
Hash:2715875b652966235103eac77e95f1e4bc345c73 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143894187 TriggerType:PUSH TriggerID:2715875b652966235103eac77e95f1e4bc345c73
-->
## CI report:
* 2715875b652966235103eac77e95f1e4bc345c73 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143894187) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4258)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10828: [FLINK-15460][JDBC] planner dependencies won't be necessary for JDBC …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10828: [FLINK-15460][JDBC] planner dependencies won't be necessary for JDBC …
URL: https://github.com/apache/flink/pull/10828#issuecomment-573039067
<!--
Meta data
Hash:2715875b652966235103eac77e95f1e4bc345c73 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4258 TriggerType:PUSH TriggerID:2715875b652966235103eac77e95f1e4bc345c73
Hash:2715875b652966235103eac77e95f1e4bc345c73 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143894187 TriggerType:PUSH TriggerID:2715875b652966235103eac77e95f1e4bc345c73
-->
## CI report:
* 2715875b652966235103eac77e95f1e4bc345c73 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143894187) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4258)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10828: [FLINK-15460][JDBC] planner dependencies won't be necessary for JDBC …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10828: [FLINK-15460][JDBC] planner dependencies won't be necessary for JDBC …
URL: https://github.com/apache/flink/pull/10828#issuecomment-573039067
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2715875b652966235103eac77e95f1e4bc345c73",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4258",
"triggerID" : "2715875b652966235103eac77e95f1e4bc345c73",
"triggerType" : "PUSH"
}, {
"hash" : "2715875b652966235103eac77e95f1e4bc345c73",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/143894187",
"triggerID" : "2715875b652966235103eac77e95f1e4bc345c73",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2715875b652966235103eac77e95f1e4bc345c73 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143894187) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4258)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10828: [FLINK-15460][JDBC] planner dependencies won't be necessary for JDBC …
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10828: [FLINK-15460][JDBC] planner dependencies won't be necessary for JDBC …
URL: https://github.com/apache/flink/pull/10828#issuecomment-573027226
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 2715875b652966235103eac77e95f1e4bc345c73 (Fri Jan 10 13:03:57 UTC 2020)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15460).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10828: [FLINK-15460][JDBC] planner dependencies won't be necessary for JDBC …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10828: [FLINK-15460][JDBC] planner dependencies won't be necessary for JDBC …
URL: https://github.com/apache/flink/pull/10828#issuecomment-573039067
<!--
Meta data
Hash:2715875b652966235103eac77e95f1e4bc345c73 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4258 TriggerType:PUSH TriggerID:2715875b652966235103eac77e95f1e4bc345c73
Hash:2715875b652966235103eac77e95f1e4bc345c73 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143894187 TriggerType:PUSH TriggerID:2715875b652966235103eac77e95f1e4bc345c73
-->
## CI report:
* 2715875b652966235103eac77e95f1e4bc345c73 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143894187) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4258)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services