You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2012/05/26 11:22:14 UTC
[Bug 119421] New: [PATCH] Writer confused by overlapping grammar
errors
https://issues.apache.org/ooo/show_bug.cgi?id=119421
Priority: P3
Bug ID: 119421
CC: ooo-issues@incubator.apache.org
Assignee: issues@lingucomponent.openoffice.org
Summary: [PATCH] Writer confused by overlapping grammar errors
Severity: normal
Issue Type: DEFECT
Classification: Code
OS: All
Reporter: misc2006@danielnaber.de
Hardware: PC
Status: UNCONFIRMED
Version: OOo 3.4 Beta
Component: other
Product: lingucomponent
Created attachment 77604
--> https://issues.apache.org/ooo/attachment.cgi?id=77604&action=edit
fix for the problem - I agree to publish this under the Apache License 2.0 or
later
Having two errors that partly overlap confuses writer, it will show the same
error message for both. That's because only the first error is considered, the
end position is ignored. The attached patch seems to fix this.
If you want to reproduce: download and install
http://www.languagetool.org/download/test/LanguageTool-20120507-snapshot-overlapping-bug-demo.oxt,
create a German document with this text: "Die falle schnappte zu." You will see
two underlines (looks like one because of the overlap): right click on "falle",
then on "schnappte" -> you will get the same error texts and suggestions,
although there are two errors. With the patch, the error does not occur
anymore.
(for reference, this bug also exists in LO at
https://bugs.freedesktop.org/show_bug.cgi?id=49605)
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 119421] [PATCH] Writer confused by overlapping grammar errors
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119421
--- Comment #3 from misc2006@danielnaber.de ---
For some reason you are seeing spelling errors, not the grammar errors from LT.
Did you restart OO after installation of LT? Did you make sure the text
language is set to German?
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 119421] [PATCH] Writer confused by overlapping grammar errors
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119421
Ariel Constenla-Haile <ar...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |122015
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 119421] [PATCH] Writer confused by overlapping grammar errors
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119421
--- Comment #11 from SVN Robot <sv...@dev.null.org> ---
"arielch" committed SVN revision 1465509 into trunk:
i119421 - Use the right comparison operator
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 119421] [PATCH] Writer confused by overlapping grammar errors
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119421
liupingtan <do...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |CONFIRMED
CC| |doneyourself@gmail.com
Ever confirmed|0 |1
--- Comment #1 from liupingtan <do...@gmail.com> ---
no reproduce
pls refernce the capture.png
the step:
download and install
http://www.languagetool.org/download/test/LanguageTool-20120507-snapshot-overlapping-bug-demo.oxt,
create a German document with this text: "Die falle schnappte zu." You will see
two underlines (looks like one because of the overlap): right click on "falle",
then on "schnappte" ->
get the correct error texts and suggestions
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 119421] [PATCH] Writer confused by overlapping grammar errors
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119421
--- Comment #6 from misc2006@danielnaber.de ---
@Rob: this patch is still applicable to AOO 4.0, I think.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 119421] [PATCH] Writer confused by overlapping grammar errors
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119421
--- Comment #7 from SVN Robot <sv...@dev.null.org> ---
"hdu" committed SVN revision 1455480 into trunk:
#i119421# fix Writer confusion caused by overlapping grammar errors
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 119421] [PATCH] Writer confused by overlapping grammar errors
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119421
hdu@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hdu@apache.org
--- Comment #4 from hdu@apache.org ---
Thanks for the patch! But shouldn't this be a "less-or-equal" in the changed
line, else a perfectly matching error would be ignored?
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 119421] [PATCH] Writer confused by overlapping grammar errors
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119421
Ariel Constenla-Haile <ar...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution|--- |FIXED
--- Comment #12 from Ariel Constenla-Haile <ar...@apache.org> ---
Fixed on trunk.
When verifying, please test that there is no regression, with the steps in bug
122015 comment 2
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 119421] [PATCH] Writer confused by overlapping grammar errors
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119421
Ariel Constenla-Haile <ar...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |arielch@apache.org
Issue Type|DEFECT |PATCH
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 119421] [PATCH] Writer confused by overlapping grammar errors
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119421
--- Comment #2 from liupingtan <do...@gmail.com> ---
Created attachment 78324
--> https://issues.apache.org/ooo/attachment.cgi?id=78324&action=edit
capture.png
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 119421] [PATCH] Writer confused by overlapping grammar errors
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119421
--- Comment #10 from Ariel Constenla-Haile <ar...@apache.org> ---
Created attachment 80504
--> https://issues.apache.org/ooo/attachment.cgi?id=80504&action=edit
Bug doc
Right-clicking in falle should display a grammar context menu, right-clicking
in schnappte should display a different grammar context menu.
Currently, right-clicking in schnappte display a common context menu, not the
grammar context menu.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 119421] [PATCH] Writer confused by overlapping grammar errors
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119421
Ariel Constenla-Haile <ar...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |---
--- Comment #9 from Ariel Constenla-Haile <ar...@apache.org> ---
The patch does not work, it causes regression described in bug 122015
Looks like it wasn't tested with a grammar checker before committing it.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 119421] [PATCH] Writer confused by overlapping grammar errors
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119421
hdu@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Hardware|PC |All
Resolution|--- |FIXED
Target Milestone|--- |AOO 4.0
--- Comment #8 from hdu@apache.org ---
Thanks Daniel! I applied this for the next target AOO4.0.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 119421] [PATCH] Writer confused by overlapping grammar errors
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119421
--- Comment #5 from Rob Weir <ro...@apache.org> ---
I'm adding this comment to all open issues with Issue Type == PATCH. We have
220 such issues, many of them quite old. I apologize for that.
We need your help in prioritizing which patches should be integrated into our
next release, Apache OpenOffice 4.0.
If you have submitted a patch and think it is applicable for AOO 4.0, please
respond with a comment to let us know.
On the other hand, if the patch is no longer relevant, please let us know that
as well.
If you have any general questions or want to discuss this further, please send
a note to our dev mailing list: dev@openoffice.apache.org
Thanks!
-Rob
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.