You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/12 05:55:18 UTC

[GitHub] [apisix-dashboard] idbeta opened a new issue #1035: bug: create route with plugin, will be error

idbeta opened a new issue #1035:
URL: https://github.com/apache/apisix-dashboard/issues/1035


   # Bug report
   
   ## Describe the bug
   
   create route with plugin, will be error
   
   ## How to Reproduce
   
   1. create route with route, but the route config json is error, so when finish commit the route, it will prompt an error, which is correct
   ![image](https://user-images.githubusercontent.com/7396835/101976564-58036f80-3c81-11eb-8ac8-ec18310e5907.png)
   ```
   {"name":"test","desc":"","uris":["/name"],"methods":["GET","HEAD","POST","PUT","DELETE","OPTIONS","PATCH"],"priority":0,"plugins":{"limit-count":{"disable":false,"policy":"local","rejected_code":503}},"vars":[],"upstream":{"type":"roundrobin","timeout":{"connect":6000,"send":6000,"read":6000},"nodes":[{"host":"127.0.0.1","port":80,"weight":1}]}}
   ```
   2. but when I go back to route config, and disable the plugin,  when finish commit the route again, it also will prompt an error, which is wrong
   ```
   {"name":"test","desc":"","uris":["/name"],"methods":["GET","HEAD","POST","PUT","DELETE","OPTIONS","PATCH"],"priority":0,"plugins":{"limit-count":{"disable":true,"policy":"local","rejected_code":503}},"vars":[],"upstream":{"type":"roundrobin","timeout":{"connect":6000,"send":6000,"read":6000},"nodes":[{"host":"127.0.0.1","port":80,"weight":1}]}}
   ```
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1035: bug: create route with plugin, will be error

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1035:
URL: https://github.com/apache/apisix-dashboard/issues/1035#issuecomment-743718966


   Need a discussion on if we MUST have valid data no matter enable or disable that plugin.
   
   cc @nic-chen @idbeta @membphis 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan closed issue #1035: bug: create route with plugin, will be error

Posted by GitBox <gi...@apache.org>.
juzhiyuan closed issue #1035:
URL: https://github.com/apache/apisix-dashboard/issues/1035


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org