You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "damonxue (via GitHub)" <gi...@apache.org> on 2023/02/15 06:28:43 UTC
[GitHub] [skywalking] damonxue opened a new pull request, #10392: Refactor version attribute to a property.
damonxue opened a new pull request, #10392:
URL: https://github.com/apache/skywalking/pull/10392
Refactor version attribute to a property.
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] damonxue commented on pull request #10392: Refactor version attribute to a property.
Posted by "damonxue (via GitHub)" <gi...@apache.org>.
damonxue commented on PR #10392:
URL: https://github.com/apache/skywalking/pull/10392#issuecomment-1430852090
@wu-sheng After release a new version, we should bump the snapshot version to a new snapshot version by a commit that had to change many pom files.
[last version commit](https://github.com/apache/skywalking/commit/18008aa6b24ada6602d9c73e1a9d19b6105d8b59)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #10392: Refactor version attribute to a property.
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #10392:
URL: https://github.com/apache/skywalking/pull/10392#issuecomment-1430854701
Yes, that change is automatically done through a script, rather than manually.
This is a typical and official release work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #10392: Refactor version attribute to a property.
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #10392:
URL: https://github.com/apache/skywalking/pull/10392#issuecomment-1430837090
Why do we do this? This version is bumped up automatically by maven command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] damonxue commented on pull request #10392: Refactor version attribute to a property.
Posted by "damonxue (via GitHub)" <gi...@apache.org>.
damonxue commented on PR #10392:
URL: https://github.com/apache/skywalking/pull/10392#issuecomment-1430869396
> No, it is done by release manager with a common maven command.
Ok, i kown, it's versions-maven-plugin command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed pull request #10392: Refactor version attribute to a property.
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng closed pull request #10392: Refactor version attribute to a property.
URL: https://github.com/apache/skywalking/pull/10392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] damonxue commented on pull request #10392: Refactor version attribute to a property.
Posted by "damonxue (via GitHub)" <gi...@apache.org>.
damonxue commented on PR #10392:
URL: https://github.com/apache/skywalking/pull/10392#issuecomment-1430865409
> Yes, that change is automatically done through a script, rather than manually. This is a typical and official release work.
Ok, I know, it's a CI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #10392: Refactor version attribute to a property.
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #10392:
URL: https://github.com/apache/skywalking/pull/10392#issuecomment-1430866775
No, it is done by release manager with a common maven command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org