You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/05/19 03:33:07 UTC
[GitHub] [dubbo-go-hessian2] champly opened a new pull request #191: fix get attachment lost nil key
champly opened a new pull request #191:
URL: https://github.com/apache/dubbo-go-hessian2/pull/191
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes get attachment lost nil key, if the value is empty, get attachment will lost it
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] champly commented on pull request #191: fix get attachment lost nil key
Posted by GitBox <gi...@apache.org>.
champly commented on pull request #191:
URL: https://github.com/apache/dubbo-go-hessian2/pull/191#issuecomment-631883788
#192
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] codecov-commenter commented on pull request #191: fix get attachment lost nil key
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #191:
URL: https://github.com/apache/dubbo-go-hessian2/pull/191#issuecomment-630563522
# [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/191?src=pr&el=h1) Report
> Merging [#191](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/191?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo-go-hessian2/commit/62debf01640d37f9250211f34c886842a3955f79&el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/191?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #191 +/- ##
==========================================
- Coverage 67.63% 67.55% -0.08%
==========================================
Files 22 22
Lines 2688 2691 +3
==========================================
Hits 1818 1818
- Misses 665 667 +2
- Partials 205 206 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/191?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [request.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/191/diff?src=pr&el=tree#diff-cmVxdWVzdC5nbw==) | `59.13% <0.00%> (-0.87%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/191?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/191?src=pr&el=footer). Last update [62debf0...80cf8b7](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/191?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] AlexStocks commented on a change in pull request #191: fix get attachment lost nil key
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #191:
URL: https://github.com/apache/dubbo-go-hessian2/pull/191#discussion_r427047262
##########
File path: request.go
##########
@@ -23,9 +23,7 @@ import (
"strconv"
"strings"
"time"
-)
Review comment:
pls add it manually by yourself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] champly commented on pull request #191: fix get attachment lost nil key
Posted by GitBox <gi...@apache.org>.
champly commented on pull request #191:
URL: https://github.com/apache/dubbo-go-hessian2/pull/191#issuecomment-631857452
> @champly pls add an unit test for this pr.
already add unit test. PTAL
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] AlexStocks commented on pull request #191: fix get attachment lost nil key
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on pull request #191:
URL: https://github.com/apache/dubbo-go-hessian2/pull/191#issuecomment-631849885
@champly pls add an unit test for this pr.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] codecov-commenter edited a comment on pull request #191: fix get attachment lost nil key
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #191:
URL: https://github.com/apache/dubbo-go-hessian2/pull/191#issuecomment-630563522
# [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/191?src=pr&el=h1) Report
> Merging [#191](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/191?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo-go-hessian2/commit/62debf01640d37f9250211f34c886842a3955f79&el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/191?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #191 +/- ##
==========================================
- Coverage 67.63% 67.55% -0.08%
==========================================
Files 22 22
Lines 2688 2691 +3
==========================================
Hits 1818 1818
- Misses 665 667 +2
- Partials 205 206 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/191?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [request.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/191/diff?src=pr&el=tree#diff-cmVxdWVzdC5nbw==) | `59.13% <0.00%> (-0.87%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/191?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/191?src=pr&el=footer). Last update [62debf0...e63ea66](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/191?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] AlexStocks commented on a change in pull request #191: fix get attachment lost nil key
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #191:
URL: https://github.com/apache/dubbo-go-hessian2/pull/191#discussion_r427017011
##########
File path: request.go
##########
@@ -23,9 +23,7 @@ import (
"strconv"
"strings"
"time"
-)
-import (
Review comment:
pls do not delete it.
##########
File path: request.go
##########
@@ -23,9 +23,7 @@ import (
"strconv"
"strings"
"time"
-)
Review comment:
pls do not delete it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] champly commented on a change in pull request #191: fix get attachment lost nil key
Posted by GitBox <gi...@apache.org>.
champly commented on a change in pull request #191:
URL: https://github.com/apache/dubbo-go-hessian2/pull/191#discussion_r427050122
##########
File path: request.go
##########
@@ -23,9 +23,7 @@ import (
"strconv"
"strings"
"time"
-)
Review comment:
OK，i manually import it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] AlexStocks commented on a change in pull request #191: fix get attachment lost nil key
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #191:
URL: https://github.com/apache/dubbo-go-hessian2/pull/191#discussion_r428425708
##########
File path: request_test.go
##########
@@ -80,3 +81,37 @@ func TestDescRegex(t *testing.T) {
assert.Equal(t, "[Ljava/lang/String;", results[0])
assert.Equal(t, "[I", results[1])
}
+
+func TestToMapStringString(t *testing.T) {
Review comment:
maybe u can create an issue for this pr, #1113 for example. And then, u can rename this test func name to TestIssue1113.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] AlexStocks merged pull request #191: fix get attachment lost nil key
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #191:
URL: https://github.com/apache/dubbo-go-hessian2/pull/191
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] codecov-commenter edited a comment on pull request #191: fix get attachment lost nil key
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #191:
URL: https://github.com/apache/dubbo-go-hessian2/pull/191#issuecomment-630563522
# [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/191?src=pr&el=h1) Report
> Merging [#191](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/191?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo-go-hessian2/commit/62debf01640d37f9250211f34c886842a3955f79&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/191?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #191 +/- ##
==========================================
+ Coverage 67.63% 67.67% +0.03%
==========================================
Files 22 22
Lines 2688 2691 +3
==========================================
+ Hits 1818 1821 +3
Misses 665 665
Partials 205 205
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/191?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [request.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/191/diff?src=pr&el=tree#diff-cmVxdWVzdC5nbw==) | `60.57% <100.00%> (+0.57%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/191?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/191?src=pr&el=footer). Last update [62debf0...1c1f810](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/191?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] champly commented on a change in pull request #191: fix get attachment lost nil key
Posted by GitBox <gi...@apache.org>.
champly commented on a change in pull request #191:
URL: https://github.com/apache/dubbo-go-hessian2/pull/191#discussion_r427017619
##########
File path: request.go
##########
@@ -23,9 +23,7 @@ import (
"strconv"
"strings"
"time"
-)
Review comment:
i don't delete it, it just auto format merge import
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] codecov-commenter edited a comment on pull request #191: fix get attachment lost nil key
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #191:
URL: https://github.com/apache/dubbo-go-hessian2/pull/191#issuecomment-630563522
# [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/191?src=pr&el=h1) Report
> Merging [#191](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/191?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo-go-hessian2/commit/62debf01640d37f9250211f34c886842a3955f79&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/191?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #191 +/- ##
==========================================
+ Coverage 67.63% 67.67% +0.03%
==========================================
Files 22 22
Lines 2688 2691 +3
==========================================
+ Hits 1818 1821 +3
Misses 665 665
Partials 205 205
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/191?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [request.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/191/diff?src=pr&el=tree#diff-cmVxdWVzdC5nbw==) | `60.57% <100.00%> (+0.57%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/191?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/191?src=pr&el=footer). Last update [62debf0...2bf7e9c](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/191?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org