You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "cuiziweizw (via GitHub)" <gi...@apache.org> on 2025/01/03 08:19:55 UTC

[PR] sim/oneshot: Remove redundant variables. [nuttx]

cuiziweizw opened a new pull request, #15418:
URL: https://github.com/apache/nuttx/pull/15418

   ## Summary
   
   
   ## Impact
   
   ## Testing
   
   ci test
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] sim/oneshot: Remove redundant variables. [nuttx]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #15418:
URL: https://github.com/apache/nuttx/pull/15418


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] sim/oneshot: Remove redundant variables. [nuttx]

Posted by "nuttxpr (via GitHub)" <gi...@apache.org>.
nuttxpr commented on PR #15418:
URL: https://github.com/apache/nuttx/pull/15418#issuecomment-2568850125

   [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
   
   
   
   ## Summary
   
   This PR appears **incomplete** and does not fully meet the NuttX requirements.  It lacks crucial information about the actual changes being made.  The summary provides no context on the *why*, *what*, or *how* of the change.  There are no issue references.
   
   ## Impact
   
   The impact section is entirely empty. Without this information, reviewers cannot assess the potential consequences of the change on users, the build system, hardware, documentation, security, or compatibility.
   
   ## Testing
   
   The testing section is inadequate. "ci test" is insufficient.  It needs to specify the actual host and target environments used for testing and provide *concrete* before/after logs demonstrating the issue and its resolution. Simply stating "ci test" doesn't prove anything. The logs sections are empty, making it impossible to verify the functionality.
   
   
   In short, this PR needs substantial work before it can be considered for merging.  The author needs to provide the missing information in all three sections (Summary, Impact, and Testing) to meet the NuttX requirements.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org