You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Prasad Mujumdar <pr...@cloudera.com> on 2014/11/11 04:49:00 UTC
Re: Review Request 25979: SENTRY-463 Refactor
SentryServiceClientFactory:
change "create SentryPolicyServiceClient" to static
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25979/#review60745
-----------------------------------------------------------
Ship it!
- Prasad Mujumdar
On Oct. 27, 2014, 6:39 a.m., Dapeng Sun wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25979/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2014, 6:39 a.m.)
>
>
> Review request for sentry, Arun Suresh, Lenni Kuff, Prasad Mujumdar, and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-463
> https://issues.apache.org/jira/browse/SENTRY-463
>
>
> Repository: sentry
>
>
> Description
> -------
>
> * In **SentryServiceClientFactory** the method **public SentryPolicyServiceClient create(Configuration conf) throws Exception** can be static
> * Make all **SentryPolicyServiceClient** are called from **SentryServiceClientFactory**
> * Change **SentryPolicyServiceClient** to a interface, **SentryPolicyServiceClientDefaultImpl** is default implementation
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java ac45746
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/SentryConfigTool.java 2b978d5
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListener.java 38bf8b2
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/SimpleDBProviderBackend.java b66037a
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java 65905f5
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceClientFactory.java 11545a5
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java ff6cff4
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java cc12099
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java f251ebc
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPolicyImport.java a67556b
>
> Diff: https://reviews.apache.org/r/25979/diff/
>
>
> Testing
> -------
>
> All unitTest passed in local environment.
>
>
> Thanks,
>
> Dapeng Sun
>
>