[GitHub] [incubator-kvrocks] PragmaTwice commented on a diff in pull request #1325: Allow to configure the compaction checker policy

["PragmaTwice (via GitHub)" <gi...@apache.org>]

PragmaTwice commented on code in PR #1325:
URL: https://github.com/apache/incubator-kvrocks/pull/1325#discussion_r1144872753


##########
src/config/config.h:
##########
@@ -131,6 +131,8 @@ struct Config {
   Cron compact_cron;
   Cron bgsave_cron;
   CompactionCheckerRange compaction_checker_range{-1, -1};
+  int64_t force_compact_file_age;
+  int64_t force_compact_file_min_deleted_percentage;

Review Comment:
   > A signed integer type can help avoid negative config value.
   
   Sorry but I cannot understand your reply. Could you explain it a bit more?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org