You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/05/31 07:58:39 UTC

[GitHub] [cordova-plugin-media] adriano-di-giovanni opened a new pull request #231: implement playing audio in background

adriano-di-giovanni opened a new pull request #231: implement playing audio in background
URL: https://github.com/apache/cordova-plugin-media/pull/231
 
 
   ### Platforms affected
   
   * Android
   * iOS
   
   On iOS, I only added a `startPlayingAudioInBackground` that's a proxy to`startPlayingAudio` because the latter already plays the audio in a background thread.
   
   
   ### Motivation and Context
   
   Playing audio in a separate thread on Android greatly improved the performance of our apps.
   
   ### Description
   
   I added `Media.prototype.playInBackground` to the javascript interface.
   I added the method `startPlayingAudioInBackground` to both Android and iOS native interfaces.
   
   
   ### Testing
   The changes are pretty minimal. I installed the plugin in a new cordova project and tested it manually.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org