You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/12/29 02:40:04 UTC

[GitHub] [hbase] YutSean commented on a change in pull request #3972: HBASE-26596 region_mover should gracefully ignore null response from RSGroupAdmin#getRSGroupOfServer

YutSean commented on a change in pull request #3972:
URL: https://github.com/apache/hbase/pull/3972#discussion_r776131590



##########
File path: bin/region_mover.rb
##########
@@ -493,11 +493,29 @@ def getFilename(options, targetServer, port)
   return filename
 end
 
+def getServersRSGroup(rsgroup_admin, hostname, port)
+  rsgroup = rsgroup_admin.getRSGroupOfServer(Address.fromParts(hostname,
+                                             java.lang.Integer.parseInt(port)))
+  return rsgroup unless rsgroup.nil?
+  begin
+    regions = getRegions(getConfiguration(), hostname)

Review comment:
       Fixed this in the latest commit. But I have one more question. It seems that we don't have UTs like java code for rb scripts. How could we test it currently?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org