[jira] [Commented] (CSV-226) Add CSVParser test case for standard charsets

["Gary Gregory (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CSV-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494281#comment-16494281 ] 

Gary Gregory commented on CSV-226:
----------------------------------

Hello [~aeschwabe]:

- You will have to make sure any test fixtures are committed as _binary_ files in your PR, to avoid git mucking with the files in any way.
- We list specific files in the RAT check because we want ALL files to be checked by RAT. The exclusions show that we _intend_ specific files to be ignored by RAT.
- I welcome more tests :-)

Thank you,
Gary

> Add CSVParser test case for standard charsets
> ---------------------------------------------
>
>                 Key: CSV-226
>                 URL: https://issues.apache.org/jira/browse/CSV-226
>             Project: Commons CSV
>          Issue Type: Test
>          Components: Parser
>    Affects Versions: 1.5
>            Reporter: Anson Schwabecher
>            Priority: Minor
>
> Hello, I'd like to contribute a CSVParser test suite for standard charsets as defined in java.nio.charset.StandardCharsets + UTF-32.
> This is a standalone test but is also in support of a fix for CSV-107.  It also refactors and unifies the testing around your established workaround of inserting BOMInputStream ahead of the CSVParser.
> It will take a single base UTF-8 encoded file (cstest.csv) and copy it to multiple output files (in target dir) with differing character sets, similar to the iconv tool.  Each file will then be fed into the parser to test all the BOM/NOBOM unicode variants.  I think a file based approach is still important here rather than just encoding a character stream inline as a string, that way if issues develop it's easy to inspect the data.
> I noticed in the project’s pom.xml (rat config) that you are excluding individual test resource files by name rather than using a wildcard expression to exclude every file in the directory.  Is there a reason for this? It’s much better if devs do not have to maintain this configuration.
> i.e.: switch over to a single exclude expression:
> {{<exclude>src/test/resources/**/*</exclude>}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)