[GitHub] [incubator-yunikorn-core] manirajv06 commented on pull request #267: [YUNIKORN-645] Metrics endpoint doesn't export any metrics

[GitBox <gi...@apache.org>]

manirajv06 commented on pull request #267:
URL: https://github.com/apache/incubator-yunikorn-core/pull/267#issuecomment-826281131


   > Beside the issue that was mentioned by @yangwwei for the other _successful_ status codes I can also see an issue around error handling and non success codes. If we set `http.StatusInternalServerError` because we have encountered a problem when writing the body via the json encoder, we try to redo that same thing again. Similar for any error in the 400 range.
   
   Intent was to convey the message to the client in case of any issues in sending json formatted error response. To avoid the cyclic dependency, was trying to send the message in plain text format with `http.StatusInternalServerError` because client depends on status code for first level checks before even trying to interpret the actual message (response body).
   
   Now, logging only as ERROR and onus comes on the Infra admin to understand the reasons as part of general debugging. Thoughts?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org