You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@netbeans.apache.org by vieiro <gi...@git.apache.org> on 2017/10/12 16:23:08 UTC

[GitHub] incubator-netbeans pull request #131: [NETBEANS-54] Module Review lib.termin...

GitHub user vieiro opened a pull request:

    https://github.com/apache/incubator-netbeans/pull/131

    [NETBEANS-54] Module Review lib.terminalemulator

      - Added Apache license to different files.
      - genfiles.properties, build-impl.xml and manifest.mf files to be handled centrally.
      - No other licensing issues found.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vieiro/incubator-netbeans netbeans-54-module-review-lib.terminalemulator

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-netbeans/pull/131.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #131
    
----
commit fb537c4edb3a891267df85fb79d5ac331d18975d
Author: Antonio Vieiro <an...@vieiro.net>
Date:   2017-10-12T16:15:22Z

    [NETBEANS-54] Module Review lib.terminalemulator
    
      - Added Apache license to different files.
      - genfiles.properties, build-impl.xml and manifest.mf files to be handled centrally.
      - No other licensing issues found.

----


---

[GitHub] incubator-netbeans issue #131: [NETBEANS-54] Module Review lib.terminalemula...

Posted by vieiro <gi...@git.apache.org>.

Github user vieiro commented on the issue:

    https://github.com/apache/incubator-netbeans/pull/131
  
    Definitely, expect this whithin 24-48h from now. Sorry & thanks for the link.


---

[GitHub] incubator-netbeans issue #131: [NETBEANS-54] Module Review lib.terminalemula...

Posted by vieiro <gi...@git.apache.org>.

Github user vieiro commented on the issue:

    https://github.com/apache/incubator-netbeans/pull/131
  
    Should be ready now.


---

[GitHub] incubator-netbeans issue #131: [NETBEANS-54] Module Review lib.terminalemula...

Posted by matthiasblaesing <gi...@git.apache.org>.

Github user matthiasblaesing commented on the issue:

    https://github.com/apache/incubator-netbeans/pull/131
  
    There are a few files were you added the ALv2 at the end of the file. As most license scanners expect it at the top, it would be good to retain that assumption. So could you update these files accordingly?
    
    If you need a short form of the license, it is available: http://www.apache.org/legal/src-headers.html#is-a-short-form-of-the-source-header-available


---