[GitHub] [superset] ktmud commented on a change in pull request #12969: chore: add more required checks for branch protection

[GitBox <gi...@apache.org>]

ktmud commented on a change in pull request #12969:
URL: https://github.com/apache/superset/pull/12969#discussion_r571304279



##########
File path: .asf.yaml
##########
@@ -61,8 +61,12 @@ github:
         # contexts are the names of checks that must pass
         contexts:
           - check
+          - docker-release

Review comment:
       Wait a minute.... `docker-release` should not be in the required list. It's only triggered on `replease:published` event:
   
   https://github.com/apache/superset/blob/master/.github/workflows/docker-release.yml#L4-L5
   
   You probably want the [Docker / build](https://github.com/apache/superset/blob/master/.github/workflows/docker.yml#L10-L11) job instead.
   
   <img width="1045" alt="docker-build" src="https://user-images.githubusercontent.com/335541/107099311-31b40900-67c6-11eb-857f-a87fefdba163.png">
   
   (Would be nice to rename this to `docker-build`, too.
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org